Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for Help FastAPI#1692

Merged
tiangolo merged 15 commits into
fastapi:masterfrom
tokusumi:translation/add-japanese-help-fastapi
Oct 17, 2020
Merged

🌐 Add Japanese translation for Help FastAPI#1692
tiangolo merged 15 commits into
fastapi:masterfrom
tokusumi:translation/add-japanese-help-fastapi

Conversation

@tokusumi

@tokusumi tokusumi commented Jul 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR translates the help-fastapi.md to Japanese.
Please review help-fastapi.md

Issue #1571 generates a new directory to support Japanese.
I will fix dependency after #1571 is merged.

@tokusumi tokusumi mentioned this pull request Jul 8, 2020
Closed
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Jul 10, 2020
SwftAlpc
SwftAlpc suggested changes Aug 15, 2020
View reviewed changes

@SwftAlpc SwftAlpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a very good translation, but you forgot to erase a few sentences, so if you could fix that it would be perfect!

Comment thread docs/ja/docs/help-fastapi.md Outdated
Comment thread docs/ja/docs/help-fastapi.md Outdated
Comment thread docs/ja/docs/help-fastapi.md Outdated
@tokusumi
Delete a few unused original sentences
9a12d73 
* delete original sentences I forgot to erase
* improve some translation
@codecov

codecov Bot commented Aug 15, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1692 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1692   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa62d92...cc3c6aa. Read the comment docs.

@github-actions

github-actions Bot commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 9a12d73 at: https://5f37c2aed56b5b3e94b425ea--fastapi.netlify.app

SwftAlpc
SwftAlpc approved these changes Aug 15, 2020
View reviewed changes

@SwftAlpc SwftAlpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

LGTM

@github-actions

github-actions Bot commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3af2bc8 at: https://5f4a707db8506640ed43d46e--fastapi.netlify.app

komtaki
komtaki reviewed Sep 25, 2020
View reviewed changes

@komtaki komtaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translate. 👍
I commented to make it read easier as Japanese.

Comment thread docs/ja/docs/help-fastapi.md Outdated
Comment thread docs/ja/docs/help-fastapi.md Outdated
Comment thread docs/ja/docs/help-fastapi.md Outdated
@tokusumi

tokusumi commented Sep 25, 2020

Copy link
Copy Markdown
Contributor Author

@komtaki
Thank you!

@github-actions

github-actions Bot commented Sep 25, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 885514b at: https://5f6e090cc012941c2abccc9f--fastapi.netlify.app

@komtaki

komtaki commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

LGTM 🙆‍♂️

@tokusumi

tokusumi commented Sep 26, 2020

Copy link
Copy Markdown
Contributor Author

@komtaki could you approve this?

@tokusumi

tokusumi commented Sep 26, 2020

Copy link
Copy Markdown
Contributor Author

Hi, @tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@tiangolo

tiangolo commented Oct 17, 2020

Copy link
Copy Markdown
Member

Awesome! Thanks @tokusumi ! ☕ 🚀

And thanks @SwftAlpc and @komtaki for the reviews 🙇 🤓

@tiangolo tiangolo changed the title Add Japanese translation for help-fastapi.md 🌐 Add Japanese translation for Help FastAPI Oct 17, 2020
@tiangolo tiangolo merged commit 2836e10 into fastapi:master Oct 17, 2020
@tokusumi tokusumi deleted the translation/add-japanese-help-fastapi branch January 18, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@komtaki komtaki komtaki approved these changes

@SwftAlpc SwftAlpc SwftAlpc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tokusumi @komtaki @tiangolo @SwftAlpc @ryuckel