Fix empty message about raised exception#1815
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1815 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 235 235
Lines 6989 6833 -156
==========================================
- Hits 6989 6833 -156
Continue to review full report at Codecov.
|
Contributor
|
📝 Docs preview for commit df17f57 at: https://5f22e34b127c7c469e7479bd--fastapi.netlify.app |
Kludex
approved these changes
Jul 30, 2020
Contributor
Author
@Kludex No, we don't. Next exception handler is correct: manlix@lab:~$ curl http://localhost:8000/items/incorrect
{"detail":[{"loc":["path","item_id"],"msg":"value is not a valid integer","type":"type_error.integer"}]}Output in logs has expected details in plain text: OMG! The client sent invalid data!: 1 validation error for Request
path -> item_id
value is not a valid integer (type=type_error.integer)
INFO: 127.0.0.1:50902 - "GET /items/incorrect HTTP/1.1" 422 Unprocessable Entity |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue in documentation example code #1814