Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for Tutorial - CORS#2125

Merged
tiangolo merged 4 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-cors
Oct 18, 2020
Merged

🌐 Add Japanese translation for Tutorial - CORS#2125
tiangolo merged 4 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-cors

Conversation

@tokusumi

@tokusumi tokusumi commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

This PR translates the tutorial/cors.md to Japanese.

@tokusumi tokusumi mentioned this pull request Oct 3, 2020
Closed
@codecov

codecov Bot commented Oct 3, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc9733...b67b7db. Read the comment docs.

@github-actions

github-actions Bot commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2dc99fe at: https://5f78874188884673c6230ebd--fastapi.netlify.app

komtaki
komtaki reviewed Oct 3, 2020
View reviewed changes

@komtaki komtaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the careful work.
I commented to read easily and more natural. 👍

Comment thread docs/ja/docs/tutorial/cors.md Outdated
Comment thread docs/ja/docs/tutorial/cors.md Outdated
Comment thread docs/ja/docs/tutorial/cors.md Outdated
Comment thread docs/ja/docs/tutorial/cors.md Outdated
Comment thread docs/ja/docs/tutorial/cors.md Outdated
@tokusumi

tokusumi commented Oct 4, 2020

Copy link
Copy Markdown
Contributor Author

@komtaki thank you for your review

@github-actions

github-actions Bot commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit ebbb7bd at: https://5f794c40218ca0a416455508--fastapi.netlify.app

komtaki
komtaki approved these changes Oct 4, 2020
View reviewed changes

@komtaki komtaki left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

Attsun1031
Attsun1031 reviewed Oct 4, 2020
View reviewed changes

@Attsun1031 Attsun1031 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work ! 👍
Please check my review comments.

Comment thread docs/ja/docs/tutorial/cors.md Outdated
Comment thread docs/ja/docs/tutorial/cors.md Outdated
Comment thread docs/ja/docs/tutorial/cors.md Outdated
Attsun1031
Attsun1031 reviewed Oct 4, 2020
View reviewed changes
Comment thread docs/ja/docs/tutorial/cors.md
@github-actions

github-actions Bot commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 4c84002 at: https://5f79d8b5c2c10c33c274072a--fastapi.netlify.app

@tokusumi

tokusumi commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

@Attsun1031 your suggestions were applied. please check it.

Attsun1031
Attsun1031 approved these changes Oct 6, 2020
View reviewed changes

@Attsun1031 Attsun1031 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Oct 15, 2020
@tiangolo tiangolo changed the title Add japanese translation for tutorial/cors.md 🌐 Add Japanese translation for Tutorial - CORS Oct 18, 2020
@tiangolo

tiangolo commented Oct 18, 2020

Copy link
Copy Markdown
Member

Awesome, thank you @tokusumi ! 🍰

And thanks @Attsun1031 and @komtaki for the reviews! 🙇

@tiangolo tiangolo merged commit 91ffa0e into fastapi:master Oct 18, 2020
@tokusumi tokusumi deleted the translation/add-ja-cors branch October 18, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Attsun1031 Attsun1031 Attsun1031 approved these changes

@komtaki komtaki komtaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 hacktoberfest-accepted lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi @tiangolo @Attsun1031 @komtaki