Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for Advanced Tutorial - Response Directly#2191

Merged
tiangolo merged 6 commits into
fastapi:masterfrom
Attsun1031:translation/add-japanese-doc-advance-response-directly
Nov 5, 2020
Merged

🌐 Add Japanese translation for Advanced Tutorial - Response Directly#2191
tiangolo merged 6 commits into
fastapi:masterfrom
Attsun1031:translation/add-japanese-doc-advance-response-directly

Conversation

@Attsun1031

@Attsun1031 Attsun1031 commented Oct 18, 2020

Copy link
Copy Markdown
Contributor

This PR translates the advanced/response-directly.md to Japanese.

@Attsun1031 Attsun1031 mentioned this pull request Oct 18, 2020
Closed
@codecov

codecov Bot commented Oct 18, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790fa21...30234f4. Read the comment docs.

@github-actions

github-actions Bot commented Oct 18, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b04a24d at: https://5f8bddc92ff9405832abf230--fastapi.netlify.app

@github-actions

github-actions Bot commented Oct 18, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 7f66de3 at: https://5f8beb99f3a8268708266a0e--fastapi.netlify.app

tokusumi
tokusumi suggested changes Oct 29, 2020
View reviewed changes

@tokusumi tokusumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for great work!

Comment thread docs/ja/docs/advanced/response-directly.md Outdated
Comment thread docs/ja/docs/advanced/response-directly.md Outdated
Comment thread docs/ja/docs/advanced/response-directly.md Outdated
Comment thread docs/ja/docs/advanced/response-directly.md Outdated
Comment thread docs/ja/docs/advanced/response-directly.md Outdated
Comment thread docs/ja/docs/advanced/response-directly.md Outdated
@Attsun1031

Attsun1031 commented Oct 30, 2020

Copy link
Copy Markdown
Contributor Author

@tokusumi Thank you for your review ! Every your suggestion are applied, so please check again.

@github-actions

github-actions Bot commented Oct 30, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2a31143 at: https://5f9b6bc2a324101c9bb41006--fastapi.netlify.app

tokusumi
tokusumi approved these changes Oct 30, 2020
View reviewed changes

@tokusumi tokusumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cooperating!

komtaki
komtaki reviewed Nov 2, 2020
View reviewed changes

@komtaki komtaki left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for your work. 👍

I commented a few small suggestions.

Comment thread docs/ja/docs/advanced/response-directly.md Outdated
Comment thread docs/ja/docs/advanced/response-directly.md Outdated
@Attsun1031

Attsun1031 commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

@komtaki Thank you for your review ! I fixed everything, so please check again.

@github-actions

github-actions Bot commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit c78712e at: https://5fa21758817493444118613f--fastapi.netlify.app

komtaki
komtaki approved these changes Nov 4, 2020
View reviewed changes

@komtaki komtaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update 👍

@tiangolo tiangolo changed the title Add Japanese translation for Advanced - response-directly 🌐 Add Japanese translation for Advanced Tutorial - Response Directly Nov 5, 2020
@github-actions

github-actions Bot commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 30234f4 at: https://5fa480cb2fceaf012c696c06--fastapi.netlify.app

@tiangolo tiangolo merged commit d31648c into fastapi:master Nov 5, 2020
@tiangolo

tiangolo commented Nov 5, 2020

Copy link
Copy Markdown
Member

Awesome, thank you @Attsun1031 ! 🍰 🎉

And thanks for the reviews @komtaki and @tokusumi 🙇 ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@komtaki komtaki komtaki approved these changes

@tokusumi tokusumi tokusumi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 hacktoberfest-accepted lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Attsun1031 @tiangolo @komtaki @tokusumi