Thanks to visit codestin.com
Credit goes to github.com

Skip to content

📌 Pin SQLAlchemy range for tests, as it doesn't use SemVer#3001

Merged
tiangolo merged 1 commit into
masterfrom
pin-sqlalchemy
Mar 27, 2021
Merged

📌 Pin SQLAlchemy range for tests, as it doesn't use SemVer#3001
tiangolo merged 1 commit into
masterfrom
pin-sqlalchemy

Conversation

@tiangolo

@tiangolo tiangolo commented Mar 27, 2021

Copy link
Copy Markdown
Member

📌 Pin SQLAlchemy range for tests, as it doesn't use SemVer and I forgot (or didn't know?) that when I pinned it the first time.

This only affects FastAPI internal tests... and by accident, Pydantic tests. 😬 🙈

@codecov

codecov Bot commented Mar 27, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3001 (a72827b) into master (4d208b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3001   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09e950...a72827b. Read the comment docs.

@github-actions github-actions Bot temporarily deployed to commit March 27, 2021 16:35 Inactive
@github-actions

github-actions Bot commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://605f5ea9c78bfb159ba56a2e--fastapi.netlify.app

@tiangolo tiangolo merged commit 36721d4 into master Mar 27, 2021
@tiangolo tiangolo deleted the pin-sqlalchemy branch March 27, 2021 16:36
@Kludex

Kludex commented Mar 27, 2021

Copy link
Copy Markdown
Member

databases already solved this issue, discussions: #2996 and encode/databases#299

@tiangolo

tiangolo commented Mar 27, 2021

Copy link
Copy Markdown
Member Author

Thanks @Kludex for the heads up! I was convinced FastAPI was also affected as it has a direct dependency on SQLAlchemy and it had a too-open range (given SQLAlchemy doesn't follow SemVer). But now I realize that probably none of the code in FastAPI itself was really affected by the new SQLAlchemy release. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tiangolo @Kludex