Thanks to visit codestin.com
Credit goes to github.com

Skip to content

✏️ Add a missing comma in the security tutorial#3564

Merged
tiangolo merged 5 commits into
fastapi:masterfrom
jalvaradosegura:add-missing-comma-in-tutorial
Oct 7, 2021
Merged

✏️ Add a missing comma in the security tutorial#3564
tiangolo merged 5 commits into
fastapi:masterfrom
jalvaradosegura:add-missing-comma-in-tutorial

Conversation

@jalvaradosegura

Copy link
Copy Markdown
Contributor

There is a missing comma in the list of things that the paragraph is mentioning

@tiangolo tiangolo enabled auto-merge (squash) July 21, 2021 12:49
@tiangolo

Copy link
Copy Markdown
Member

Good catch, thank you @jalvaradosegura! 🙇 🔍

@codecov

codecov Bot commented Jul 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3564 (96e0364) into master (eb453a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3564   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10264     10264           
=========================================
  Hits         10264     10264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb453a5...96e0364. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 270cc2d at: https://60f818275bc56534a985a4cf--fastapi.netlify.app

auto-merge was automatically disabled July 21, 2021 16:22

Pull request was closed

@jalvaradosegura

Copy link
Copy Markdown
Contributor Author

More than happy to contribute to this incredible framework @tiangolo 🙇‍♂️

I have one question though. It seems that something is happening with the build-docs check, is taking quite a while.
I tried to solve this by closing and then opening the PR as stated in this answer

Is this normal? Am I not doing something? What should I do?

This is my first time contributing to a repository of this level, I'm tagging some of the FastAPI experts to kindly ask for their help🙏 @Kludex @frankie567

@github-actions

github-actions Bot commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 29fce2d at: https://615f0160201e9225059b0769--fastapi.netlify.app

@tiangolo tiangolo enabled auto-merge (squash) October 7, 2021 14:29
@github-actions

github-actions Bot commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 96e0364 at: https://615f04f14150f337c9f95e09--fastapi.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants