Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add French translation for docs/fr/docs/deployment/index.md#3689

Merged
tiangolo merged 10 commits into
fastapi:masterfrom
rjNemo:feature/translation-fr-deployment-intro
Aug 18, 2022
Merged

🌐 Add French translation for docs/fr/docs/deployment/index.md#3689
tiangolo merged 10 commits into
fastapi:masterfrom
rjNemo:feature/translation-fr-deployment-intro

Conversation

@rjNemo

@rjNemo rjNemo commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

🤗

Here is the PR to translate the deployment intro.
See the french translation tracking issue here.

Thanks for the reviews

@rjNemo rjNemo changed the title Add French translation for deployment/index.md 🌐 Add French translation for deployment/index.md Aug 12, 2021
@codecov

codecov Bot commented Aug 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3689 (3a54345) into master (2aaac14) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #3689   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       532    +1     
  Lines        13629     13672   +43     
=========================================
+ Hits         13629     13672   +43
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
tests/test_schema_extra_examples.py 100.00% <0.00%> (ø)
docs_src/dependencies/tutorial001.py 100.00% <0.00%> (ø)
docs_src/dependency_testing/tutorial001.py 100.00% <0.00%> (ø)
docs_src/body_multiple_params/tutorial003.py 100.00% <0.00%> (ø)
docs_src/schema_extra_example/tutorial004.py 100.00% <0.00%> (ø)
docs_src/additional_status_codes/tutorial001.py 100.00% <0.00%> (ø)
docs_src/body_multiple_params/tutorial003_py310.py 100.00% <0.00%> (ø)
docs_src/schema_extra_example/tutorial004_py310.py 100.00% <0.00%> (ø)
.../query_params_str_validations/tutorial014_py310.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aaac14...3a54345. Read the comment docs.

@github-actions

github-actions Bot commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 567c354 at: https://6114ce4eb773bd7e578cf3da--fastapi.netlify.app

@github-actions

github-actions Bot commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 37ee682 at: https://6114d0fdcc2d51748610f988--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-fr French translations labels Aug 18, 2021
@github-actions github-actions Bot mentioned this pull request Aug 18, 2021
Closed
@github-actions

github-actions Bot commented Aug 22, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 710a203 at: https://61220e61f67165d21c9bb328--fastapi.netlify.app

@github-actions

github-actions Bot commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 76014e8 at: https://61f12eface347a905df6a9c7--fastapi.netlify.app

@github-actions

github-actions Bot commented May 11, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 5b147b1 at: https://627b9399fc0e5463a411dcf7--fastapi.netlify.app

arthurio
arthurio approved these changes Jul 6, 2022
View reviewed changes

@arthurio arthurio left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻 🇫🇷
However, I just checked https://github.com/tiangolo/fastapi/blob/master/docs/en/docs/deployment/index.md and looks like there is more to translate now?

arthurio
arthurio suggested changes Jul 6, 2022
View reviewed changes

@arthurio arthurio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see that it was out of sync with current english version, but the translation was great!

@rjNemo

rjNemo commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

@arthurio I review the recent version as soon as possible.
Thanks for pointing it out

@rjNemo

rjNemo commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

@arthurio I pushed the latest changes.
Can you please review it again?

@github-actions

github-actions Bot commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit f991d34 at: https://62c68c71c8ef8c4da59ee500--fastapi.netlify.app

arthurio
arthurio reviewed Jul 8, 2022
View reviewed changes

@arthurio arthurio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions, otherwise looks great 🤩

Comment thread docs/fr/docs/deployment/index.md
utilisateurs**.

Pour une **API Web**, cela implique normalement de la placer sur une **machine distante**, avec un **programme serveur**
qui offre de bonnes performances, une bonne stabilité, _etc._, afin que vos **utilisateurs** puissent **accéder** à

@arthurio arthurio Jul 8, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why _ect._ instead of just etc.?

@rjNemo rjNemo Jul 8, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned that Latin terms should be written in italics.

@arthurio arthurio Jul 8, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info 😃

Comment thread docs/fr/docs/deployment/index.md Outdated
@github-actions

github-actions Bot commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3a54345 at: https://62c7db7569e707538f566159--fastapi.netlify.app

arthurio
arthurio approved these changes Jul 8, 2022
View reviewed changes

@arthurio arthurio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯

@tiangolo tiangolo changed the title 🌐 Add French translation for deployment/index.md 🌐 Add French translation for docs/fr/docs/deployment/index.md Aug 18, 2022
@tiangolo

tiangolo commented Aug 18, 2022

Copy link
Copy Markdown
Member

Awesome, thanks @rjNemo! 🍰

And thanks for the reviews @arthurio and @Smlep! ☕

@tiangolo tiangolo merged commit e5eb56f into fastapi:master Aug 18, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
@rjNemo @arthurio
@pre-commit-ci @JeanArhancet
🌐 Add French translation for docs/fr/docs/deployment/index.md (fast…
bae9c24 
…api#3689)

Co-authored-by: Arthur Rio <[email protected]>
Co-authored-by: Ruidy <[email protected]>
Co-authored-by: Ruidy <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@arthurio arthurio arthurio approved these changes

@Smlep Smlep Smlep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-fr French translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rjNemo @tiangolo @arthurio @Smlep