Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Korean translation for docs/ko/docs/deployment/versions.md#4121

Merged
tiangolo merged 10 commits into
fastapi:masterfrom
DevDae:docs-deployment-versions
Dec 8, 2021
Merged

🌐 Add Korean translation for docs/ko/docs/deployment/versions.md#4121
tiangolo merged 10 commits into
fastapi:masterfrom
DevDae:docs-deployment-versions

Conversation

@DevDae

@DevDae DevDae commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

0417taehyun
0417taehyun reviewed Nov 1, 2021
View reviewed changes

@0417taehyun 0417taehyun left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to check my reviews!

It's honor to check yours 🚀

PS. It would be better to add a file path in mkdocs.yml, which in docs/ko.

Comment thread docs/ko/docs/deployment/versions.md Outdated
Comment thread docs/ko/docs/deployment/versions.md Outdated
Comment thread docs/ko/docs/deployment/versions.md Outdated
Comment thread docs/ko/docs/deployment/versions.md Outdated
0417taehyun
0417taehyun reviewed Nov 1, 2021
View reviewed changes

@0417taehyun 0417taehyun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add the reviews because of word, 애플리케이션.

If you check 파이썬 한국어 번역 and search word, application, it is translated as 응용 프로그램 and because we follows the rules of that guide (check of it on #2017 ).

Big appreciate your works 🚀

Comment thread docs/ko/docs/deployment/versions.md Outdated
Comment thread docs/ko/docs/deployment/versions.md Outdated
Comment thread docs/ko/docs/deployment/versions.md Outdated
Comment thread docs/ko/docs/deployment/versions.md Outdated
DevDae and others added 8 commits November 3, 2021 15:18
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
5c5ca52 
Co-authored-by: weekwith.me <[email protected]>
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
383a690 
Co-authored-by: weekwith.me <[email protected]>
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
de14dca 
Co-authored-by: weekwith.me <[email protected]>
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
4378043 
Co-authored-by: weekwith.me <[email protected]>
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
d1f8c3d 
Co-authored-by: weekwith.me <[email protected]>
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
1907755 
Co-authored-by: weekwith.me <[email protected]>
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
fe3661c 
Co-authored-by: weekwith.me <[email protected]>
@DevDae @0417taehyun
Update docs/ko/docs/deployment/versions.md
71308b1 
Co-authored-by: weekwith.me <[email protected]>
@0417taehyun

0417taehyun commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

LGTM 🚀

PS.
If you help review others, it will be help of Korean seeing docs easily and better 🥳
There are several pull requests waiting for reviews (check #2017 ).

@DevDae

DevDae commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

LGTM 🚀

PS. If you help review others, it will be help of Korean seeing docs easily and better 🥳 There are several pull requests waiting for reviews (check #2017 ).

Sure, i will check other reviews for flourishing Korean translations! thanks! 😆

0417taehyun
0417taehyun approved these changes Nov 3, 2021
View reviewed changes

@0417taehyun 0417taehyun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiangolo

This is PERFECT 🚀

@tiangolo tiangolo added approved-2 lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@tiangolo

tiangolo commented Dec 8, 2021

Copy link
Copy Markdown
Member

Amazing, thanks for your contribution @DevDae! 🍪

And thanks for the reviews @kty4119 and and @0417taehyun! 👏 🍰

@tiangolo tiangolo merged commit 446d194 into fastapi:master Dec 8, 2021
@kritsada1998mtcn-ctrl kritsada1998mtcn-ctrl mentioned this pull request Nov 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kty4119 kty4119 kty4119 approved these changes

@0417taehyun 0417taehyun 0417taehyun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DevDae @0417taehyun @tiangolo @kty4119