🐛 Fix support for extending openapi_extras with parameter lists#4267
Merged
Conversation
…llows query parameters to be specified in openapi_extras not be appended to the spec, not overwrite.
openapi_extras with parameter lists
Member
|
Awesome, thanks for the contribution @orilevari! 🚀 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #4267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 534 535 +1
Lines 13811 13830 +19
=========================================
+ Hits 13811 13830 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Is there a way to fall back to the old functionality somehow? 🤔 We have We might do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When specifying parameters in openapi_extras for an endpoint, they will overwrite the existing query parameters with the extra parameters. This is due to deep_dict_update in utils.py overwriting list types rather than merging them together.
PR Content
This PR updates deep_dict_update to merge arrays instead of overwriting. I have also added a test case that demonstrates and verifies the desired behavior.
Testing
Ran bash scripts/test-cov-html.sh with 100% test pass including new test case