Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (9e7ec21) compared to base (7ff6246).
Patch has no changes to coverable lines.

@@            Coverage Diff            @@
##            master     #4971   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13946     13946           
=========================================
  Hits         13946     13946           

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

📝 Docs preview for commit 37e04df at: https://6295d912b2eeb81e2e62dd3f--fastapi.netlify.app

I reviewed your changes and made some optimization. Can I push them ?

Sure

I reviewed your changes and made some optimization. Can I push them ?

Sure

But it seems I have no permission:

$ git push zssaer head:zssaer-translation-classes-as-dependencies
ERROR: Permission to Zssaer/fastapi.git denied to Jedore.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Am I something wrong ? Or how can I push changes to this PR? Or can I only comment some lines in per review. Because I reviewed and changed much lines. Thanks. @tiangolo @Zssaer

I reviewed your changes and made some optimization. Can I push them ?

Sure

But it seems I have no permission:

$ git push zssaer head:zssaer-translation-classes-as-dependencies
ERROR: Permission to Zssaer/fastapi.git denied to Jedore.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Am I something wrong ? Or how can I push changes to this PR? Or can I only comment some lines in per review. Because I reviewed and changed much lines. Thanks. @tiangolo @Zssaer

Looks like you don't have permission to do that. See

I reviewed your changes and made some optimization. Can I push them ?

Sure

But it seems I have no permission:

$ git push zssaer head:zssaer-translation-classes-as-dependencies
ERROR: Permission to Zssaer/fastapi.git denied to Jedore.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Am I something wrong ? Or how can I push changes to this PR? Or can I only comment some lines in per review. Because I reviewed and changed much lines. Thanks. @tiangolo @Zssaer

Only the upstream repository maintainers can direct change it.
Try to create pull request.

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

Jedore，你目前还是否有意愿进行提交一些修改？如果你嫌一段一段Request changes麻烦的话，我的意思是 你可以将这个PR的Branch给Fork下来，然后再进行PR给这个Branch。

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

Jedore，你目前还是否有意愿进行提交一些修改？如果你嫌一段一段Request changes麻烦的话，我的意思是 你可以将这个PR的Branch给Fork下来，然后再进行PR给这个Branch。

之前没有对你的branch推送的权限，所以我已经将我所有的修改建议在上面以review的形式提交了，需要你去按需选择接受或拒绝就可以了。目前我没有其他的修改建议了，所以也不用再提PR给你的branch了 😂

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

Jedore，你目前还是否有意愿进行提交一些修改？如果你嫌一段一段Request changes麻烦的话，我的意思是 你可以将这个PR的Branch给Fork下来，然后再进行PR给这个Branch。

之前没有对你的branch推送的权限，所以我已经将我所有的修改建议在上面以review的形式提交了，需要你去按需选择接受或拒绝就可以了。目前我没有其他的修改建议了，所以也不用再提PR给你的branch了 😂

可是我并没有收到你的相关review的提交

@Zssaer 现在可以看到了吗？第一次 review， 打开review， 忘记提交review了

📝 Docs preview for commit a77ebd0 at: https://63600c790ccda20c0446c3b3--fastapi.netlify.app