Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Portuguese translation for docs/pt/docs/deployment/docker.md#5663

Merged
tiangolo merged 8 commits into
fastapi:masterfrom
ayr-ton:docs/pt-deployment-docker
Nov 27, 2022
Merged

🌐 Add Portuguese translation for docs/pt/docs/deployment/docker.md#5663
tiangolo merged 8 commits into
fastapi:masterfrom
ayr-ton:docs/pt-deployment-docker

Conversation

@ayr-ton

@ayr-ton ayr-ton commented Nov 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

There are some opportunities to update the original docker documentation but I will do that in a separated PR once this one is reviewed.

@ayr-ton ayr-ton mentioned this pull request Nov 19, 2022
Closed
@github-actions

github-actions Bot commented Nov 19, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3b00f6f at: https://637947c6ea25702ffc1536e6--fastapi.netlify.app

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch from 3b00f6f to cfc39ad Compare November 19, 2022 21:21
@github-actions

github-actions Bot commented Nov 19, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 31a65bd at: https://637949e19d407f337634905c--fastapi.netlify.app

guites
guites reviewed Nov 22, 2022
View reviewed changes
Comment thread docs/pt/docs/deployment/docker.md Outdated
@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch 2 times, most recently from dcedadb to 26301e7 Compare November 22, 2022 13:44
guites
guites suggested changes Nov 22, 2022
View reviewed changes

@guites guites left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation!

Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
@github-actions

github-actions Bot commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2f13f4b at: https://637cd370ce97bd2089131c0a--fastapi.netlify.app

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch 5 times, most recently from bcbc6ad to eff095f Compare November 22, 2022 14:05
@github-actions

github-actions Bot commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 8d98626 at: https://637cd86b5146b825bd329679--fastapi.netlify.app

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch from 8d98626 to 57752de Compare November 22, 2022 14:14
@ayr-ton

ayr-ton commented Nov 22, 2022

Copy link
Copy Markdown
Contributor Author

@guites Thank you for your time reviewing! 😄

@github-actions

github-actions Bot commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 715c676 at: https://637cda5a2db5a7292bc631d8--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations lang-pt Portuguese translations awaiting-review labels Nov 23, 2022
guites
guites approved these changes Nov 23, 2022
View reviewed changes

@guites guites left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the author fixed all points except for a few nitpicks, which is ok.

izaguerreiro
izaguerreiro reviewed Nov 23, 2022
View reviewed changes
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
Comment thread docs/pt/docs/deployment/docker.md Outdated
@ayr-ton

ayr-ton commented Nov 23, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for your time reviewing! Working in @izaguerreiro suggestions and will let you know once is ready.

@github-actions

github-actions Bot commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 017851f at: https://637eb15ea69c556e0f656597--fastapi.netlify.app

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch from 017851f to 81829ef Compare November 23, 2022 23:51
@github-actions

github-actions Bot commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 81829ef at: https://637eb2b727e28360fbf48e93--fastapi.netlify.app

@ayr-ton

ayr-ton commented Nov 24, 2022

Copy link
Copy Markdown
Contributor Author

Ready

@github-actions

github-actions Bot commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 4426332 at: https://637f710d3f0ba606981921e6--fastapi.netlify.app

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch from 7bd4506 to 4426584 Compare November 24, 2022 18:10
@ayr-ton

ayr-ton commented Nov 24, 2022

Copy link
Copy Markdown
Contributor Author

Missed the nitpicks.
Just fixed them, @guites o/
Thanks again

@github-actions

github-actions Bot commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 4426584 at: https://637fb44f89f6414c4fe8f264--fastapi.netlify.app

@ayr-ton

ayr-ton commented Nov 25, 2022

Copy link
Copy Markdown
Contributor Author

The PR #5680 seems to fix the libffi error that is breaking the build.

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch from 4426584 to 22c4e9c Compare November 25, 2022 19:49
@github-actions

github-actions Bot commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 22c4e9c at: https://63811d25adf1a06dc6911306--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Portuguese translation for deployment/docker.md 🌐 Add Portuguese translation for docs/pt/docs/deployment/docker.md Nov 27, 2022
@tiangolo

tiangolo commented Nov 27, 2022

Copy link
Copy Markdown
Member

Awesome, thank you! 🙇

And thanks a lot for the reviews @izaguerreiro and @guites ☕ 🍰

@tiangolo tiangolo enabled auto-merge (squash) November 27, 2022 14:04
@github-actions

github-actions Bot commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 688b45b at: https://63837073218017641c11a8a0--fastapi.netlify.app

@tiangolo tiangolo merged commit ebd917a into fastapi:master Nov 27, 2022
@ayr-ton ayr-ton deleted the docs/pt-deployment-docker branch November 28, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@izaguerreiro izaguerreiro izaguerreiro approved these changes

@guites guites guites approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-pt Portuguese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ayr-ton @tiangolo @izaguerreiro @guites