Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix validating of list annotation in forms parsing#856

Merged
tiangolo merged 1 commit into
fastapi:masterfrom
nsidnev:fix-lists-in-forms
Jan 17, 2020
Merged

Fix validating of list annotation in forms parsing#856
tiangolo merged 1 commit into
fastapi:masterfrom
nsidnev:fix-lists-in-forms

Conversation

@nsidnev

@nsidnev nsidnev commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

Closes #842

@codecov

codecov Bot commented Jan 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #856 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #856   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         289    290    +1     
  Lines        7595   7620   +25     
=====================================
+ Hits         7595   7620   +25
Impacted Files Coverage Δ
tests/test_forms_from_non_typing_sequences.py 100% <100%> (ø)
fastapi/dependencies/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eca945...24a6c45. Read the comment docs.

@dmontagu dmontagu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tiangolo tiangolo merged commit 874d241 into fastapi:master Jan 17, 2020
@tiangolo

Copy link
Copy Markdown
Member

Awesome, thanks @nsidnev for debugging and implementing the fix with extensive tests 👏 🙇‍♂️ 🚀 🍰

Thanks @dmontagu as always! 🚀 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support repeated key=value in form data

3 participants