📝 Update example source files for SQL databases with SQLAlchemy#9508
Merged
Conversation
Contributor
|
📝 Docs preview for commit dba9733 at: https://645a09454c03c83c4b2f2175--fastapi.netlify.app |
Ryandaydev
approved these changes
May 17, 2023
Ryandaydev
left a comment
There was a problem hiding this comment.
This change makes intuitive sense, and I verified SQLAlchemy doco does not include the index=true for its examples of defining primary keys.
Tests also pass.
Kludex
approved these changes
Jul 18, 2023
Member
|
📝 Docs preview for commit 077a31f at: https://64b6f023ad95e206b42d3dc0--fastapi.netlify.app |
Member
|
Thank you! ☕ 🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a secondary index to a primary key is not necessary.