Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 26b95da

Browse files
kirkwaiblingerkirkwaiblinger
authored
fix: no-useless-template-expression -> no-unnecessary-template-expression (typescript-eslint#9174)
* no-useless-template-expression -> no-unnecessary-template-expression * sort keys
1 parent 6ebb757 commit 26b95da

18 files changed

+114
-114
lines changed

‎packages/eslint-plugin/docs/rules/no-useless-template-expression.mdx renamed to ‎packages/eslint-plugin/docs/rules/no-unnecessary-template-expression.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ import TabItem from '@theme/TabItem';
77

88
> 🛑 This file is source code, not the primary documentation location! 🛑
99
>
10-
> See **https://typescript-eslint.io/rules/no-useless-template-expression** for documentation.
10+
> See **https://typescript-eslint.io/rules/no-unnecessary-template-expression** for documentation.
1111
1212
This rule reports template literals that contain substitution expressions (also variously referred to as embedded expressions or string interpolations) that are unnecessary and can be simplified.
1313

1414
:::info[Migration from `no-useless-template-literals`]
1515

1616
This rule was formerly known as [`no-useless-template-literals`](./no-useless-template-literals.mdx).
17-
We encourage users to migrate to the new name, `no-useless-template-expression`, as the old name will be removed in a future major version of typescript-eslint.
17+
We encourage users to migrate to the new name, `no-unnecessary-template-expression`, as the old name will be removed in a future major version of typescript-eslint.
1818

1919
The new name is a drop-in replacement with identical functionality.
2020

‎packages/eslint-plugin/docs/rules/no-useless-template-literals.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import TabItem from '@theme/TabItem';
1212
This rule reports template literals that contain substitution expressions (also variously referred to as embedded expressions or string interpolations) that are unnecessary and can be simplified.
1313

1414
:::warning
15-
This rule is being renamed to [`no-useless-template-expression`](./no-useless-template-expression.mdx).
15+
This rule is being renamed to [`no-unnecessary-template-expression`](./no-unnecessary-template-expression.mdx).
1616
The current name, `no-useless-template-literals`, will be removed in a future major version of typescript-eslint.
1717

1818
After the creation of this rule, it was realized that the name `no-useless-template-literals` could be misleading, seeing as this rule only targets template literals with substitution expressions.

‎packages/eslint-plugin/src/configs/all.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ export = {
113113
'no-useless-constructor': 'off',
114114
'@typescript-eslint/no-useless-constructor': 'error',
115115
'@typescript-eslint/no-useless-empty-export': 'error',
116-
'@typescript-eslint/no-useless-template-expression': 'error',
116+
'@typescript-eslint/no-unnecessary-template-expression': 'error',
117117
'@typescript-eslint/no-var-requires': 'error',
118118
'@typescript-eslint/non-nullable-type-assertion-style': 'error',
119119
'no-throw-literal': 'off',

‎packages/eslint-plugin/src/configs/disable-type-checked.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export = {
3939
'@typescript-eslint/no-unsafe-member-access': 'off',
4040
'@typescript-eslint/no-unsafe-return': 'off',
4141
'@typescript-eslint/no-unsafe-unary-minus': 'off',
42-
'@typescript-eslint/no-useless-template-expression': 'off',
42+
'@typescript-eslint/no-unnecessary-template-expression': 'off',
4343
'@typescript-eslint/no-useless-template-literals': 'off',
4444
'@typescript-eslint/non-nullable-type-assertion-style': 'off',
4545
'@typescript-eslint/only-throw-error': 'off',

‎packages/eslint-plugin/src/configs/strict-type-checked-only.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export = {
3333
'@typescript-eslint/no-unsafe-enum-comparison': 'error',
3434
'@typescript-eslint/no-unsafe-member-access': 'error',
3535
'@typescript-eslint/no-unsafe-return': 'error',
36-
'@typescript-eslint/no-useless-template-expression': 'error',
36+
'@typescript-eslint/no-unnecessary-template-expression': 'error',
3737
'no-throw-literal': 'off',
3838
'@typescript-eslint/only-throw-error': 'error',
3939
'@typescript-eslint/prefer-includes': 'error',

‎packages/eslint-plugin/src/configs/strict-type-checked.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export = {
6060
'@typescript-eslint/no-unused-vars': 'error',
6161
'no-useless-constructor': 'off',
6262
'@typescript-eslint/no-useless-constructor': 'error',
63-
'@typescript-eslint/no-useless-template-expression': 'error',
63+
'@typescript-eslint/no-unnecessary-template-expression': 'error',
6464
'@typescript-eslint/no-var-requires': 'error',
6565
'no-throw-literal': 'off',
6666
'@typescript-eslint/only-throw-error': 'error',

‎packages/eslint-plugin/src/rules/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ import noTypeAlias from './no-type-alias';
8181
import noUnnecessaryBooleanLiteralCompare from './no-unnecessary-boolean-literal-compare';
8282
import noUnnecessaryCondition from './no-unnecessary-condition';
8383
import noUnnecessaryQualifier from './no-unnecessary-qualifier';
84+
import noUnnecessaryTemplateExpression from './no-unnecessary-template-expression';
8485
import noUnnecessaryTypeArguments from './no-unnecessary-type-arguments';
8586
import noUnnecessaryTypeAssertion from './no-unnecessary-type-assertion';
8687
import noUnnecessaryTypeConstraint from './no-unnecessary-type-constraint';
@@ -97,7 +98,6 @@ import noUnusedVars from './no-unused-vars';
9798
import noUseBeforeDefine from './no-use-before-define';
9899
import noUselessConstructor from './no-useless-constructor';
99100
import noUselessEmptyExport from './no-useless-empty-export';
100-
import noUselessTemplateExpression from './no-useless-template-expression';
101101
import noUselessTemplateLiterals from './no-useless-template-literals';
102102
import noVarRequires from './no-var-requires';
103103
import nonNullableTypeAssertionStyle from './non-nullable-type-assertion-style';
@@ -227,6 +227,7 @@ export default {
227227
'no-unnecessary-boolean-literal-compare': noUnnecessaryBooleanLiteralCompare,
228228
'no-unnecessary-condition': noUnnecessaryCondition,
229229
'no-unnecessary-qualifier': noUnnecessaryQualifier,
230+
'no-unnecessary-template-expression': noUnnecessaryTemplateExpression,
230231
'no-unnecessary-type-arguments': noUnnecessaryTypeArguments,
231232
'no-unnecessary-type-assertion': noUnnecessaryTypeAssertion,
232233
'no-unnecessary-type-constraint': noUnnecessaryTypeConstraint,
@@ -243,7 +244,6 @@ export default {
243244
'no-use-before-define': noUseBeforeDefine,
244245
'no-useless-constructor': noUselessConstructor,
245246
'no-useless-empty-export': noUselessEmptyExport,
246-
'no-useless-template-expression': noUselessTemplateExpression,
247247
'no-useless-template-literals': noUselessTemplateLiterals,
248248
'no-var-requires': noVarRequires,
249249
'non-nullable-type-assertion-style': nonNullableTypeAssertionStyle,

‎packages/eslint-plugin/src/rules/no-useless-template-expression.ts renamed to ‎packages/eslint-plugin/src/rules/no-unnecessary-template-expression.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ import {
1111
isUndefinedIdentifier,
1212
} from '../util';
1313

14-
type MessageId = 'noUselessTemplateExpression';
14+
type MessageId = 'noUnnecessaryTemplateExpression';
1515

1616
export default createRule<[], MessageId>({
17-
name: 'no-useless-template-expression',
17+
name: 'no-unnecessary-template-expression',
1818
meta: {
1919
fixable: 'code',
2020
type: 'suggestion',
@@ -24,7 +24,7 @@ export default createRule<[], MessageId>({
2424
requiresTypeChecking: true,
2525
},
2626
messages: {
27-
noUselessTemplateExpression:
27+
noUnnecessaryTemplateExpression:
2828
'Template literal expression is unnecessary and can be simplified.',
2929
},
3030
schema: [],
@@ -91,7 +91,7 @@ export default createRule<[], MessageId>({
9191
if (hasSingleStringVariable) {
9292
context.report({
9393
node: node.expressions[0],
94-
messageId: 'noUselessTemplateExpression',
94+
messageId: 'noUnnecessaryTemplateExpression',
9595
fix(fixer): TSESLint.RuleFix[] {
9696
const [prevQuasi, nextQuasi] = node.quasis;
9797

@@ -125,7 +125,7 @@ export default createRule<[], MessageId>({
125125
fixableExpressions.forEach(expression => {
126126
context.report({
127127
node: expression,
128-
messageId: 'noUselessTemplateExpression',
128+
messageId: 'noUnnecessaryTemplateExpression',
129129
fix(fixer): TSESLint.RuleFix[] {
130130
const index = node.expressions.indexOf(expression);
131131
const prevQuasi = node.quasis[index];

‎packages/eslint-plugin/src/rules/no-useless-template-literals.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
isUndefinedIdentifier,
1212
} from '../util';
1313

14-
type MessageId = 'noUselessTemplateExpression';
14+
type MessageId = 'noUnnecessaryTemplateExpression';
1515

1616
export default createRule<[], MessageId>({
1717
name: 'no-useless-template-literals',
@@ -23,12 +23,12 @@ export default createRule<[], MessageId>({
2323
requiresTypeChecking: true,
2424
},
2525
messages: {
26-
noUselessTemplateExpression:
26+
noUnnecessaryTemplateExpression:
2727
'Template literal expression is unnecessary and can be simplified.',
2828
},
2929
schema: [],
3030
deprecated: true,
31-
replacedBy: ['@typescript-eslint/no-useless-template-expression'],
31+
replacedBy: ['@typescript-eslint/no-unnecessary-template-expression'],
3232
},
3333
defaultOptions: [],
3434
create(context) {
@@ -92,7 +92,7 @@ export default createRule<[], MessageId>({
9292
if (hasSingleStringVariable) {
9393
context.report({
9494
node: node.expressions[0],
95-
messageId: 'noUselessTemplateExpression',
95+
messageId: 'noUnnecessaryTemplateExpression',
9696
fix(fixer): TSESLint.RuleFix[] {
9797
const [prevQuasi, nextQuasi] = node.quasis;
9898

@@ -126,7 +126,7 @@ export default createRule<[], MessageId>({
126126
fixableExpressions.forEach(expression => {
127127
context.report({
128128
node: expression,
129-
messageId: 'noUselessTemplateExpression',
129+
messageId: 'noUnnecessaryTemplateExpression',
130130
fix(fixer): TSESLint.RuleFix[] {
131131
const index = node.expressions.indexOf(expression);
132132
const prevQuasi = node.quasis[index];

‎packages/eslint-plugin/tests/docs-eslint-output-snapshots/no-useless-template-expression.shot renamed to ‎packages/eslint-plugin/tests/docs-eslint-output-snapshots/no-unnecessary-template-expression.shot

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)