Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Review Clippy Flags #3572

@bradjc

Description

@bradjc

We run clippy as part of CI, with the following flags:

tock/tools/run_clippy.sh

Lines 26 to 43 in 910821a

CLIPPY_ARGS="
-A clippy::complexity
-A clippy::pedantic
-A clippy::nursery
-A clippy::style
-A clippy::perf
-A clippy::cargo
-A clippy::restriction
-A clippy::if_same_then_else
-D clippy::needless_return
-D clippy::unnecessary_mut_passed
-D clippy::empty_line_after_outer_attr
-D clippy::default_trait_access
-D clippy::map_unwrap_or
-D clippy::wildcard_imports
"

These flags were chosen when we added clippy to minimize the amount of re-writing of code. However, we should revisit these flags to increase the number of checks clippy is helping us with by improving the source tree incrementally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions