Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-460
What's in this PR?
Handles several security issues as per PM-460:
❌ [Low] Improper Type Validation
Path: src/apps/earn/src/reducers/challenge-listing/index.js, line 970
❌ [Low] Improper Type Validation
Path: src/apps/earn/src/reducers/challenge-listing/index.js, line 971
✔️ [Medium] Permissive Cross-domain Policy
Path: src/apps/learn/src/free-code-camp/fcc-frame/FccFrame.tsx, line 38
✔️ [Medium] Cross-site Scripting (XSS)
Path: src/libs/ui/lib/components/tabs-navbar/TabsNavbar.tsx, line 115
✔️ [High] Hardcoded Secret
Path: src/apps/earn/src/config/prod.ts, line 14
✔️ [High] Hardcoded Secret
Path: src/apps/earn/src/config/dev.ts, line 12
✔️ [High] Cross-site Scripting (XSS)
Path: src/apps/learn/src/course-details/course-curriculum/dice-modal/DiceModal.tsx, line 52
✔️ [High] Cross-site Scripting (XSS)
Path: src/apps/self-service/src/components/work-details/details/sidebar/WorkDetailDetailsSidebar.tsx, line 43
✔️ [High] Cross-site Scripting (XSS)
Path: src/apps/self-service/src/components/work-details/details/sidebar/WorkDetailDetailsSidebar.tsx, line 53
✔️ [High] Cross-site Scripting (XSS)
Path: src/apps/self-service/src/components/work-details/details/sidebar/WorkDetailDetailsSidebar.tsx, line 63