Some work on testing

dennisschroer · dennisschroer · commit 47171ef2a9a8 · 2018-04-02T21:38:08.000+02:00
diff --git a/src/test/groovy/nl/topicus/overheid/javafactorybot/AbstractModelFactoryTest.groovy b/src/test/groovy/nl/topicus/overheid/javafactorybot/AbstractModelFactoryTest.groovy
diff --git a/src/test/groovy/nl/topicus/overheid/javafactorybot/BaseFactoryTest.groovy b/src/test/groovy/nl/topicus/overheid/javafactorybot/BaseFactoryTest.groovy
@@ -0,0 +1,52 @@
+package nl.topicus.overheid.javafactorybot
+
+import nl.topicus.overheid.javafactorybot.test.factory.ArticleFactory
+import nl.topicus.overheid.javafactorybot.test.model.Article
+import nl.topicus.overheid.javafactorybot.test.model.User
+import spock.lang.Specification
+import spock.lang.Subject
+
+class BaseFactoryTest extends Specification {
+    @Subject
+    ArticleFactory factory = new ArticleFactory()
+
+    def "it fills the attributes when no overrides are given"() {
+        when:
+        Article article = new ArticleFactory().build()
+
+        then: "defined attributes with default are filled"
+        article.title != null
+        article.content != null
+        article.creationDate != null
+
+        and: "defined attributes with default null are null"
+        article.summary == null
+
+        and: "relations are set"
+        article.author != null
+        article.author instanceof User
+        article.comments != null
+        article.comments.size() == 0
+
+        and: "nondefined attributes are not filled"
+        article.slug == null
+    }
+
+    def "it uses overrides"() {
+        when:
+        Article article = factory.build([title: "foo", slug: "derp"])
+
+        then: "overrides are used"
+        article.title == "foo"
+        article.slug == "derp"
+
+        and: "remaining attributes are filled as default"
+        article.content != null
+        article.creationDate != null
+        article.summary == null
+        article.author != null
+        article.author instanceof User
+        article.comments != null
+        article.comments.size() == 0
+    }
+}
diff --git a/src/test/groovy/nl/topicus/overheid/javafactorybot/test/factory/ArticleFactory.groovy b/src/test/groovy/nl/topicus/overheid/javafactorybot/test/factory/ArticleFactory.groovy
@@ -14,6 +14,7 @@ class ArticleFactory extends Factory<Article> {
                 title       : attribute { faker.lorem().sentence() },
                 content     : attribute { faker.lorem().paragraph() },
                 creationDate: attribute { faker.date().past(20, TimeUnit.DAYS) },
+                summary     : attribute { null },
                 author      : hasOne(UserFactory),
                 comments    : hasMany(CommentFactory)
         ]
@@ -24,11 +25,6 @@ class ArticleFactory extends Factory<Article> {
         article?.comments.each { it.article = article }
     }
 
-    @Override
-    void onAfterAttributes(Map<String, Object> attributes) {
-        attributes.put("title", "foo")
-    }
-
     @Override
     Map<String, Trait> getTraits() {
         [
diff --git a/src/test/java/nl/topicus/overheid/javafactorybot/test/model/Article.java b/src/test/java/nl/topicus/overheid/javafactorybot/test/model/Article.java
@@ -11,6 +11,8 @@ public class Article {
     private String title;
     private String content;
     private Date creationDate;
+    private String slug;
+    private String summary;
 
     // Relations
     private User author;

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ class ArticleFactory extends Factory<Article> {`
`14`	`14`	`title : attribute { faker.lorem().sentence() },`
`15`	`15`	`content : attribute { faker.lorem().paragraph() },`
`16`	`16`	`creationDate: attribute { faker.date().past(20, TimeUnit.DAYS) },`
	`17`	`+ summary : attribute { null },`
`17`	`18`	`author : hasOne(UserFactory),`
`18`	`19`	`comments : hasMany(CommentFactory)`
`19`	`20`	`]`
`@@ -24,11 +25,6 @@ class ArticleFactory extends Factory<Article> {`
`24`	`25`	`article?.comments.each { it.article = article }`
`25`	`26`	`}`
`26`	`27`
`27`		`- @Override`
`28`		`- void onAfterAttributes(Map<String, Object> attributes) {`
`29`		`- attributes.put("title", "foo")`
`30`		`- }`
`31`		`-`
`32`	`28`	`@Override`
`33`	`29`	`Map<String, Trait> getTraits() {`
`34`	`30`	`[`