bug EasyCorp#6740 Bug EasyCorp#5161 Disallow clear in AssociationField when field is required (Sobak)

javiereguiluz · javiereguiluz · commit 89fb2d2a8eab · 2025-01-21T19:55:16.000+01:00
This PR was merged into the 4.x branch. Discussion ---------- Bug EasyCorp#5161 Disallow clear in AssociationField when field is required Hi, This small change closes EasyCorp#5161 and instructs the frontend library to not render the `x` button for unsetting the association completely. Admittedly, "extending" the trait methods in PHP is always weird and it's not very common, but it allows for the least amount of code repetition. This approach also doesn't require any JS changes. Please let me know if such approach is acceptable. This is my first contribution so there might be some other rules that I'm not aware of. Thanks! Commits ------- 20ff3e4 bug EasyCorp#5161 Disallow clear in AssociationField when field is required
diff --git a/src/Field/Configurator/CommonPreConfigurator.php b/src/Field/Configurator/CommonPreConfigurator.php
@@ -64,6 +64,7 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
 
         $isRequired = $this->buildRequiredOption($field, $entityDto);
         $field->setFormTypeOption('required', $isRequired);
+        $field->setHtmlAttribute('required', $isRequired);
 
         $isSortable = $this->buildSortableOption($field, $entityDto);
         $field->setSortable($isSortable);
