fix smoothing bug #601
Merged
fix smoothing bug #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
==========================================
- Coverage 99.14% 98.87% -0.28%
==========================================
Files 9 9
Lines 704 709 +5
Branches 125 127 +2
==========================================
+ Hits 698 701 +3
- Misses 3 5 +2
Partials 3 3 |
chengs
commented
Sep 7, 2018
| avg_time = delta_t / delta_it \ | ||
| if avg_time is None \ | ||
| else smoothing * delta_t / delta_it + \ | ||
| (1 - smoothing) * avg_time |
Contributor
Author
There was a problem hiding this comment.
here, avg_time is useless because it has never been read. Actually, avg_time should be written back to self.avg_time
Member
|
thanks |
…ponding int Add 'index' and 'columns' to `axis` arguments closes #570
"Rolling/Expanding.apply() accepts raw=False to pass a Series to the function"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the function
__iter__, the variablesmoothingmay not be written back to theselfobject, which causes the issue #566.This PR fix the problem by fixing a bug found by @simonm3 in #566.
Maybe helpful for #449