ensure empty candlestick trace don't lead to autotyped 'category' x-axis

etpinard · etpinard · commit 3fbb46004101 · 2017-02-06T22:37:59.000-05:00
- box traces have a special algo to handle the case where
  trace 'name' can appear on axis ticks.
diff --git a/src/plots/cartesian/axis_defaults.js b/src/plots/cartesian/axis_defaults.js
@@ -207,6 +207,7 @@ function isBoxWithoutPositionCoords(trace, axLetter) {
 
     return (
         Registry.traceIs(trace, 'box') &&
+        trace._fullInput.type === 'box' &&
         axLetter === posLetter &&
         trace[posLetter] === undefined &&
         trace[posLetter + '0'] === undefined
diff --git a/test/jasmine/tests/finance_test.js b/test/jasmine/tests/finance_test.js
@@ -367,6 +367,13 @@ describe('finance charts defaults:', function() {
             expect(fullTrace.xcalendar).toBe(i < 2 ? 'hebrew' : 'julian');
         });
     });
+
+    it('should make empty candlestick traces autotype to *linear* (as opposed to real box traces)', function() {
+        var trace0 = { type: 'candlestick' };
+        var out = _supply([trace0], { xaxis: {} });
+
+        expect(out._fullLayout.xaxis.type).toEqual('linear');
+    });
 });
 
 describe('finance charts calc transforms:', function() {
