Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip non-comparable & non-orderable field when extracting VALUES predicate #16242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2023
Merged

Skip non-comparable & non-orderable field when extracting VALUES predicate #16242

merged 1 commit into from
Feb 24, 2023

Conversation

weiatwork
Copy link
Contributor

Repro

CREATE TABLE t1 (coordinates row(x double, y double))

-- Fails with "Cannot create discrete ValueSet with non-comparable type: Geometry"
WITH ZONE (polygon) AS
    (VALUES (ST_POLYGON('polygon((0.0 0.0))')),
            (ST_POLYGON('polygon((0.0 0.0))')))
SELECT *
FROM t1
CROSS JOIN ZONE
WHERE ST_WITHIN(ST_POINT(coordinates.x, coordinates.y), polygon)

Related to #743 @martint

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
(X) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 23, 2023
@weiatwork weiatwork requested a review from martint February 23, 2023 18:30
@martint martint merged commit ddfcbd8 into trinodb:master Feb 24, 2023
@github-actions github-actions bot added this to the 409 milestone Feb 24, 2023
@weiatwork weiatwork deleted the skip-non-comparable branch February 24, 2023 17:39
@colebow colebow mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
cla-signed
Milestone
409
Development

Successfully merging this pull request may close these issues.
2 participants
@weiatwork @martint