Prevent column shift during insert#1930
Merged
findepi merged 1 commit intotrinodb:masterfrom Nov 6, 2019
Merged
Conversation
findepi
reviewed
Nov 1, 2019
Member
There was a problem hiding this comment.
Verify that y is indeed not supported.
Maybe replace
assertQuery("SELECT x, z FROM test_insert_not_supported_column", "SELECT 123, 'test'");
with
assertQuery("SELECT * FROM test_insert_not_supported_column", "SELECT 123, 'test'");
...
but having explicit check using information_schema.columns would be better
Member
There was a problem hiding this comment.
testInsertInPresenceOfNotSupportedColumn?
also, add a similar test case for mysql, sql server too
findepi
approved these changes
Nov 2, 2019
Member
There was a problem hiding this comment.
IMO this comment is redundant (same in other tests)
Member
There was a problem hiding this comment.
- remove space after table name
- rename the table to sth like
test_insert_not_supported_column_present
This change adds explicit enumeration of target columns in the final phase of insert. Before, the columns of the temporary table were copied into the leftmost columns of the target table. It caused a failure or incorrect results when a column of unsupported type was encountered.
findepi
approved these changes
Nov 3, 2019
Member
Author
|
@findepi, are there any changes required? |
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change in
BaseJdbcClientadds explicit enumeration of target columns in the final phase of insert. Before, the columns of the temporary table were copied into the leftmost columns of the target table. It caused a failure or incorrect results when a column of unsupported type was encountered.