Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Wait for and build split with dynamic filter in Kudu #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

Wait for and build split with dynamic filter in Kudu #5594

merged 1 commit into from
Nov 16, 2020

Conversation

lzeiming
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 19, 2020
Praveen2112
Praveen2112 reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR.

@lzeiming lzeiming force-pushed the lzeiming-master branch 3 times, most recently from 4201e16 to c149811 Compare October 21, 2020 01:47
@findepi findepi removed their request for review October 21, 2020 08:39
@lzeiming lzeiming force-pushed the lzeiming-master branch 3 times, most recently from edafd44 to 6c91f4d Compare October 23, 2020 08:47
@lzeiming lzeiming changed the title wait for and build split with dynamic filter in Kudu Wait for and build split with dynamic filter in Kudu Oct 23, 2020
@lzeiming lzeiming force-pushed the lzeiming-master branch 2 times, most recently from 61d54cd to a035931 Compare October 26, 2020 06:30
@lzeiming lzeiming force-pushed the lzeiming-master branch 2 times, most recently from 2c3883e to c7ac33b Compare October 27, 2020 01:37
sopel39
sopel39 reviewed Oct 27, 2020
View reviewed changes
@lzeiming lzeiming force-pushed the lzeiming-master branch 2 times, most recently from 9f2dd69 to 7b719a7 Compare November 2, 2020 09:34
sopel39
sopel39 reviewed Nov 2, 2020
View reviewed changes
@lzeiming lzeiming force-pushed the lzeiming-master branch 2 times, most recently from 4867e4e to 9b5832b Compare November 3, 2020 02:57
@lzeiming lzeiming requested a review from sopel39 November 3, 2020 03:19
@lzeiming lzeiming force-pushed the lzeiming-master branch 2 times, most recently from c70eed5 to bab7f02 Compare November 3, 2020 07:23
@lzeiming lzeiming requested a review from sopel39 November 5, 2020 02:38
@lzeiming lzeiming force-pushed the lzeiming-master branch 2 times, most recently from ebfe220 to 06768ec Compare November 6, 2020 02:00
sopel39
sopel39 reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % small comments

presto-kudu/src/main/java/io/prestosql/plugin/kudu/KuduSplitManager.java Outdated
{
if (splitSourceFuture.isDone()) {
if (splitSourceFuture.isCompletedExceptionally()) {
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it can complete exceptionally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If isFinished() is called after close(), and dynamicFilterFuture cancellation in close() succeeded, splitSourceFuture is completed exceptionally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should return true then here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, splitSource is not created since getSplitSource() is not triggered. I think return false is more reasonable.
isFinished() return false after close() should not be a problem. In FixedSplitSource, isFinished() aslo can return false after close().

@lzeiming lzeiming requested a review from sopel39 November 10, 2020 03:42
@lzeiming lzeiming force-pushed the lzeiming-master branch 2 times, most recently from 4a0eb97 to 61b3156 Compare November 12, 2020 05:42
sopel39
sopel39 approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

@sopel39
Copy link
Member

sopel39 commented Nov 13, 2020

Small comment: #5594 (comment)

@lzeiming lzeiming requested a review from sopel39 November 14, 2020 01:51
sopel39
sopel39 approved these changes Nov 16, 2020
View reviewed changes
presto-kudu/src/main/java/io/prestosql/plugin/kudu/KuduClientConfig.java
@@ -26,6 +27,8 @@
import java.util.List;
import java.util.concurrent.TimeUnit;

import static java.util.concurrent.TimeUnit.MINUTES;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: test for kudu config is missing

@sopel39 sopel39 merged commit 9a68e91 into trinodb:master Nov 16, 2020
@sopel39
Copy link
Member

sopel39 commented Nov 16, 2020

merged, thanks!

@sopel39 sopel39 mentioned this pull request Nov 16, 2020
Closed
10 tasks
@martint martint added this to the 347 milestone Nov 16, 2020
@lzeiming lzeiming deleted the lzeiming-master branch November 17, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi left review comments

@sopel39 sopel39 sopel39 approved these changes

@Praveen2112 Praveen2112 Awaiting requested review from Praveen2112

@raunaqmorarka raunaqmorarka Awaiting requested review from raunaqmorarka

Assignees
No one assigned
Labels
cla-signed
Milestone
347
Development

Successfully merging this pull request may close these issues.
6 participants
@lzeiming @sopel39 @findepi @raunaqmorarka @Praveen2112 @martint