minor symfony#4 Mark classes as final (keradus)

nicolas-grekas · nicolas-grekas · commit 6ee697261592 · 2015-10-26T07:55:25.000+01:00
This PR was merged into the 1.0-dev branch. Discussion ---------- Mark classes as final Hi! First of all, it is going to be a great lib! Then, about PR - shouldn't internal classes be final where it is possible? Commits ------- ef70c24 Mark internal classes final where possible
diff --git a/src/Iconv/Iconv.php b/src/Iconv/Iconv.php
@@ -34,7 +34,7 @@
  *
  * @internal
  */
-class Iconv
+final class Iconv
 {
     const ERROR_ILLEGAL_CHARACTER = 'iconv(): Detected an illegal character in input string';
     const ERROR_WRONG_CHARSET = 'iconv(): Wrong charset, conversion from `%s\' to `%s\' is not allowed';
diff --git a/src/Intl/Grapheme/Grapheme.php b/src/Intl/Grapheme/Grapheme.php
@@ -31,7 +31,7 @@
  *
  * @internal
  */
-class Grapheme
+final class Grapheme
 {
     // (CRLF|([ZWNJ-ZWJ]|T+|L*(LV?V+|LV|LVT)T*|L+|[^Control])[Extend]*|[Control])
     // This regular expression is a work around for http://bugs.exim.org/1279
diff --git a/src/Mbstring/Mbstring.php b/src/Mbstring/Mbstring.php
@@ -60,7 +60,7 @@
  *
  * @internal
  */
-class Mbstring
+final class Mbstring
 {
     const MB_CASE_FOLD = PHP_INT_MAX;
 
diff --git a/src/Php54/Php54.php b/src/Php54/Php54.php
@@ -16,7 +16,7 @@
  *
  * @internal
  */
-class Php54
+final class Php54
 {
     public static function hex2bin($data)
     {
diff --git a/src/Php55/Php55.php b/src/Php55/Php55.php
@@ -14,7 +14,7 @@
 /**
  * @internal
  */
-class Php55
+final class Php55
 {
     public static function boolval($val)
     {
diff --git a/src/Php55/Php55ArrayColumn.php b/src/Php55/Php55ArrayColumn.php
@@ -27,7 +27,7 @@
 /**
  * @internal
  */
-class Php55ArrayColumn
+final class Php55ArrayColumn
 {
     public static function array_column(array $input, $columnKey, $indexKey = null)
     {
diff --git a/src/Php56/Php56.php b/src/Php56/Php56.php
@@ -16,7 +16,7 @@
 /**
  * @internal
  */
-class Php56
+final class Php56
 {
     const LDAP_ESCAPE_FILTER = 1;
     const LDAP_ESCAPE_DN = 2;
diff --git a/src/Php70/Php70.php b/src/Php70/Php70.php
@@ -16,7 +16,7 @@
  *
  * @internal
  */
-class Php70
+final class Php70
 {
     public static function intdiv($dividend, $divisor)
     {
diff --git a/src/Xml/Xml.php b/src/Xml/Xml.php
@@ -16,7 +16,7 @@
  *
  * @internal
  */
-class Xml
+final class Xml
 {
     public static function utf8_encode($s)
     {

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`*`
`35`	`35`	`* @internal`
`36`	`36`	`*/`
`37`		`-class Iconv`
	`37`	`+final class Iconv`
`38`	`38`	`{`
`39`	`39`	`const ERROR_ILLEGAL_CHARACTER = 'iconv(): Detected an illegal character in input string';`
`40`	`40`	const ERROR_WRONG_CHARSET = 'iconv(): Wrong charset, conversion from `%s\' to `%s\' is not allowed';
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`*`
`32`	`32`	`* @internal`
`33`	`33`	`*/`
`34`		`-class Grapheme`
	`34`	`+final class Grapheme`
`35`	`35`	`{`
`36`	`36`	`// (CRLF\|([ZWNJ-ZWJ]\|T+\|L(LV?V+\|LV\|LVT)T\|L+\|[^Control])[Extend]*\|[Control])`
`37`	`37`	`// This regular expression is a work around for http://bugs.exim.org/1279`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@`
`60`	`60`	`*`
`61`	`61`	`* @internal`
`62`	`62`	`*/`
`63`		`-class Mbstring`
	`63`	`+final class Mbstring`
`64`	`64`	`{`
`65`	`65`	`const MB_CASE_FOLD = PHP_INT_MAX;`
`66`	`66`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`*`
`17`	`17`	`* @internal`
`18`	`18`	`*/`
`19`		`-class Php54`
	`19`	`+final class Php54`
`20`	`20`	`{`
`21`	`21`	`public static function hex2bin($data)`
`22`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`/**`
`15`	`15`	`* @internal`
`16`	`16`	`*/`
`17`		`-class Php55`
	`17`	`+final class Php55`
`18`	`18`	`{`
`19`	`19`	`public static function boolval($val)`
`20`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`/**`
`28`	`28`	`* @internal`
`29`	`29`	`*/`
`30`		`-class Php55ArrayColumn`
	`30`	`+final class Php55ArrayColumn`
`31`	`31`	`{`
`32`	`32`	`public static function array_column(array $input, $columnKey, $indexKey = null)`
`33`	`33`	`{`