@XhmikosR
I'd give myself a try on this, but I'm not sure if I fully understand the functionality.

From looking at the code, every element gets assigned an object within a bsKey property, that holds the information of some kind of unique-id and some key string to match against to. This key is used in the getData and removeData method. The unique-id is used as the key on the storeData object, with the data assigned that is passed to the setData function.

If one relies on the bsKey of that element, what exactly is the advantage of storing the data in the storeData, over storing the data on the element itself? Is this to hide things away?

Also if I understand it correctly, there can be only one {id, key} object at an elements bsKey at any time. Doesn't make this the key kind of unnecessary or is this so one doesn't get a wrong instance when the Component.getInstance() is called?

Currently the storeData looks something like this:

storeData: {
  1: TooltipInstance,
  2: ModalInstance,
  ...
}

How do you want the Map to look like and do you want me to get rid of the bsKey property?
Like Map<Id, Data> or like Map<Element, Data> or rather like Map<Element, Map<Key, Data>> or Map<Element, {Key:Data}>?

Do you prefer to use a WeakMap?

Uh oh!

Refactor data.js to use a Map #32123

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Refactor data.js to use a `Map` #32123