Thanks to visit codestin.com
Credit goes to github.com

Skip to content

setup.py - stop distributing 'tests' #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 163 commits into from
Closed

setup.py - stop distributing 'tests' #246

wants to merge 163 commits into from

Conversation

adamchainz
Copy link

Found this hanging around when I installed twilio.

Test Plan: Did tox -r -e py27, then ls .tox/py27/lib/python2.7/site-packages/tests stopped reporting the directory as existing.

AlexPayment and others added 30 commits April 27, 2015 16:51
@AlexPayment
Scoped authentication token and signing keys implementation
ef7bd68
@AlexPayment
Python 2 compatibility
ea2b9d9
@AlexPayment
Add signing key attributes documentation
a01e39b
Updating python to support Client Grants
ce0a41e 
Removed the Grant class for simplicity.  Moved the ACTION constants
up to the module scope and renamed them for their purpose.
Removing JWT support from the Client
be9c9e2
@skimbrel
Add Conversations resources
af595e7
@skimbrel
Add initial Conversations client test
4075d2b
@skimbrel
Add Conversations tests
7c38105
@skimbrel
Whoops
65b60d2
Renaming ScopedAuthenticationToken to AccessToken
188cc5e
@senthgit
Removed the SigningKeys List
d964824
@senthgit
Merge branch 'scoped-auth-tokens' of github.com:twilio/python-private…
8f2bcfd 
… into scoped-auth-tokens
@skimbrel
Add Participant tests
dbdb4a8
@mattmakai
adding signing keys to branch
461819f
New add_rest_grant and enable_nts and tests
9a2edff
Make token creation chainable
29967c2
@skimbrel
Merge branch 'conversations' into signal-beta
c577dad
@skimbrel
Merge remote-tracking branch 'github-private/scoped-auth-tokens' into…
be8fef1 
… signal-beta
@skimbrel
Add .json to Tokens in enable_nts
a20892d
@wanjunsli
porting to python
099c06d
@wanjunsli
changed __init__.py file
73f40e5
@wanjunsli
no reservation status
55c4188
@wanjunsli
wrong reservation status changed
b37a9c1
@wanjunsli
bug fix to fetch reservations
7f987b1
@jwitz10
Remove CapabilityAPI
7be9163 
Fix formatting problems (whitespaces at end of lines, line length of 80 chars, two spaces before class names, new lines at end of file, no spaces between default parameter attributes,)
Fix old capability test
@wanjunsli
Merge pull request twilio#2 from twilio/taskrouter-jwt
3505afe 
Remove CapabilityAPI
@gramanathaiah
Helper libs for workflow construction
c53d711
@wanjunsli
added helper function
15db38a
@wanjunsli
added helper function, formatting
3aaae24
@wanjunsli
forgot to remove sys path
0255c47
nookiepl and others added 9 commits February 11, 2016 14:08
@nookiepl
Fixed typo
316c6ab 
account_uri not account_url! ;)
@carlosdp
Merge pull request twilio#257 from nookiepl/patch-1
26ecc6d 
Added missing "addresses" endpoint to client.py
@pinkerton
Fix phone call -> message copypasta
c59214a
@carlosdp
Merge pull request twilio#258 from Pinkerton/patch-1
cbf00e8 
Fix phone call -> message copypasta
Add issue template
25fd789
Add API key auth support
b24dd45
Bump to version 5.4.0
089dcde
Fix the closing tag for <response>
b297a68 
The closing tag for <Response> in the sample text is missing the slash. e.g. </Response>
@carlosdp
Merge pull request twilio#261 from W7PEA/patch-1
22b84cd 
Fix the closing tag for <response>
@adamchainz adamchainz force-pushed the dont_distribute_tests branch from 1380ebd to 81c466c Compare May 13, 2016 16:53
@adamchainz
Copy link
Author

rebased, bump @carlosdp

@adamchainz
Copy link
Author

bump @carlosdp

@adamchainz adamchainz force-pushed the dont_distribute_tests branch from 81c466c to ffcd392 Compare October 7, 2016 09:50
@adamchainz
Copy link
Author

rebased, bump @ihumanable @jingming @carlosdp

@codejudas
Copy link
Contributor

codejudas commented Apr 6, 2017 •
edited
Loading

@adamchainz sorry this got ignored for so long. we just released a major redesign of the library in the 6.x series and this PR is no longer mergeable. Is this still a problem?

@codejudas codejudas closed this Apr 6, 2017
@adamchainz
Copy link
Author

Why did you close? This isn't fixed, you can easily tell for yourself by making a new virtualenv, installing twilio, then running:

$ python
Python 2.7.13 (default, Dec 18 2016, 07:03:39)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import tests
>>> tests.holodeck
<module 'tests.holodeck' from '/Users/chainz/.virtualenvs/test/lib/python2.7/site-packages/tests/holodeck.pyc'>
>>>

Github has gone crazy on the PR, I think because you've majorly modified the master branch. The only change you need to fix this pollution is my commit, ffcd392 .

@codejudas
Copy link
Contributor

@adamchainz closed it because it wasnt clear if that was still a problem and this PR was polluted with other commits. I've opened a new pr with just your change it, we'll get it into the next release, thanks for your feedback!

#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.