Unify JWT based helpers #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87d5be0 to
05133ff
Compare
dougblack
reviewed
Feb 21, 2017
twilio/jwt/__init__.py
Outdated
| def payload(self): | ||
| if self.__decoded_payload: | ||
| return self.__decoded_payload | ||
| else: |
There was a problem hiding this comment.
nit: I think it's usually clearer to write these functions that have two branches where the first is kind of a base case, short-circuity thing like
@property
def payload(self):
if self.__decoded_payload:
return self.__decoded_payload
payload = self._generate_payload().copy()
# ...
return payloadThere was a problem hiding this comment.
It visually separates the happy and sad paths.
twilio/jwt/__init__.py
Outdated
| """ | ||
|
|
||
| if not self.secret_key: | ||
| raise ValueError('Jwt does not have a signing key configured.') |
There was a problem hiding this comment.
nit: JWT is an abbreviation so it's typically fully-capitalized.
twilio/jwt/compat.py
Outdated
| @@ -0,0 +1,25 @@ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Remove blank lines at top of file.
|
+1 on content, just called out a few style things. |
dougblack
approved these changes
Feb 21, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite JWTs to all be derived from a Jwt base class, move a lot of general jwt logic into base classes. Simplify the code.
Question: I stopped short of having each Jwt subclass deserialize a jwt string into its internal representation, we could (somewhat) easily do that, wondering if its worth it. Would allow a user to deserialize a AccessToken for instance, modify it via the helper functions/have proper validation, and then re-serialize it.