Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[no-unnecessary-condition] Add an option to allow while (true) #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ark120202 opened this issue Sep 29, 2019 · 0 comments · Fixed by #1029
Closed

[no-unnecessary-condition] Add an option to allow while (true) #1015

ark120202 opened this issue Sep 29, 2019 · 0 comments · Fixed by #1029
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@ark120202
Copy link

no-constant-condition has a checkLoops to allow while (true) pattern. I think it makes sense to add a similar option to no-unnecessary-condition. Compared to checkLoops, I don't think it should ignore all loop conditions but only true literal.
@ark120202 ark120202 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Sep 29, 2019
@bradzacher bradzacher added enhancement: plugin rule option New rule option for an existing eslint-plugin rule and removed triage Waiting for team members to take a look labels Sep 30, 2019
@a-tarasyuk a-tarasyuk mentioned this issue Oct 1, 2019
Merged
@brainkim brainkim mentioned this issue Oct 11, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): [no-unnece-cond] Add allowConstantLoopConditions a-tarasyuk/typescript-eslint
2 participants
@bradzacher @ark120202