Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Repo: Speed up semantic-breaking-change-pr.yml #11206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaKGoldberg opened this issue May 12, 2025 · 0 comments
Open

Repo: Speed up semantic-breaking-change-pr.yml #11206

JoshuaKGoldberg opened this issue May 12, 2025 · 0 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue performance Issues regarding performance repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Splitting out of #11204: our semantic-breaking-change-pr.yml workflow is good and useful for making sure PRs that introduce breaking changes have the appropriate title and description.

But, per https://github.com/typescript-eslint/typescript-eslint/actions/metrics/usage, that action currently is our third biggest slice of total CI minutes. I'm seeing 613 minutes across 359 runs over the last month.

Much of that time comes from the action having to go through our full installation command:

- uses: ./.github/actions/prepare-install

Let's speed that up! I can think of a couple options to try:

  • Quick & easy: Instead of our shared installation action, we could install just the @github/* deps the JS file actually uses
  • More comprehensive: @bradzacher suggested internally that we could switch it to a standalone repo's action. Doing so would allow us to pre-compile the action as JS and make it reusable

Proposal: let's go with quick & easy for now?

Additional Info

Also related is #11205, for speeding up CI install times. But I don't think this workflow should be running a full repository install at all.

💖

@JoshuaKGoldberg JoshuaKGoldberg added performance Issues regarding performance repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue performance Issues regarding performance repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

1 participant