Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor fixture tests so they don't generate a single giant snapshot file #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue Oct 25, 2019 · 0 comments · Fixed by #2290
Closed

Refactor fixture tests so they don't generate a single giant snapshot file #1142

bradzacher opened this issue Oct 25, 2019 · 0 comments · Fixed by #2290
Labels
enhancement New feature or request has pr there is a PR raised to close this package: parser Issues related to @typescript-eslint/parser package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@bradzacher
Copy link
Member

Spawning off of #1141.

The fixture snapshots are pretty much impossible to read, and them being in one file makes the diff really hard to understand (which snapshot is which file?).

Also the snapshot format (jest's default object serialiser) makes it harder to read by adding in Object and Array everywhere.

Need to refactor all of this so that:

  • each fixture test is output its own snapshot file
  • the snapshot formatter outputs as pure JSON
@bradzacher bradzacher added enhancement New feature or request package: parser Issues related to @typescript-eslint/parser package: typescript-estree Issues related to @typescript-eslint/typescript-estree labels Oct 25, 2019
This was referenced Oct 25, 2019
Merged
Closed
@bradzacher bradzacher added the has pr there is a PR raised to close this label Oct 28, 2019
@armano2 armano2 mentioned this issue Dec 16, 2019
Closed
@armano2 armano2 mentioned this issue Dec 29, 2019
Closed
@armano2 armano2 mentioned this issue Jan 22, 2020
Closed
@bradzacher bradzacher mentioned this issue Jul 13, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request has pr there is a PR raised to close this package: parser Issues related to @typescript-eslint/parser package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
No milestone
1 participant
@bradzacher