Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[no-base-to-string] remove option ignoreTaggedTemplateExpressions #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue Apr 17, 2020 · 0 comments
Closed

[no-base-to-string] remove option ignoreTaggedTemplateExpressions #1914

bradzacher opened this issue Apr 17, 2020 · 0 comments
Labels
breaking change This change will require a new major version to be released bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Milestone
3.0.0

Comments

@bradzacher
Copy link
Member

Context: #1757 (comment)

This option should never have been added to the rule, and was added due to my misunderstanding of how tagged template expressions are type checked.
@bradzacher bradzacher added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin breaking change This change will require a new major version to be released labels Apr 17, 2020
@bradzacher bradzacher added this to the 3.0.0 milestone Apr 17, 2020
@LinusU LinusU mentioned this issue Apr 18, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@bradzacher