Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[no-non-null-asserted-optional-chain] Possible Infinite Loop #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
hjkcai opened this issue Sep 8, 2020 · 7 comments
Closed
3 tasks done

[no-non-null-asserted-optional-chain] Possible Infinite Loop #2521

hjkcai opened this issue Sep 8, 2020 · 7 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@hjkcai
Copy link

hjkcai commented Sep 8, 2020

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

{
  "rules": {
    "@typescript-eslint/no-non-null-asserted-optional-chain": "error"
  }
}
let foo1: { bar: { baz: string } } | undefined;

console.log(foo1?.bar!.baz);

Expected Result

ESLint reports error.

Actual Result

Infinite Loop.

Additional Info

I am using ESLint programmatically:

import { CLIEngine, Linter } from 'eslint';
const cli = new CLIEngine({});
cli.executeOnFiles('/path/to/the/file.ts');

But the script never ended. However this problem was not present in VSCode ESLint Plugin. I have no idea about what's happening. I am not sure the above code can reproduce the problem (because it is extracted from a large codebase).

I used the debugger to pause when infinite loop occurred. It ended up here:

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/src/rules/no-non-null-asserted-optional-chain.ts#L116

There is an obvious logical error: the break only breaks the switch statement, meanwhile current.optional is truthy, meaning current is truthy. Theoretically THE LOOP WILL NEVER STOP WHEN A OPTIONAL CHAIN IS FOUND.

while (current) {
  switch (current.type) {
    case AST_NODE_TYPES.MemberExpression:
      if (current.optional) {
        // found an optional chain! stop traversing
        break;
      }

      current = current.object;
      continue;

    case AST_NODE_TYPES.CallExpression:
      if (current.optional) {
        // found an optional chain! stop traversing
        break;
      }

      current = current.callee;
      continue;

    default:
      // something that's not a ChainElement, which means this is not an optional chain we want to check
      return;
  }
}

Versions

package version
@typescript-eslint/eslint-plugin 4.1.0
@typescript-eslint/parser 4.1.0
TypeScript 3.7.3
ESLint 6.8.0
node 12.18.2
@hjkcai hjkcai added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Sep 8, 2020
@bradzacher
Copy link
Member

We have this exact code as a passing test case, so I'm not sure why you're encountering an infinite loop.

typescript-eslint/packages/eslint-plugin/tests/rules/no-non-null-asserted-optional-chain.test.ts

Line 21 in 762bc99

'foo?.bar!.baz;',

The only reason I could see is because you're on an old version of TS, which triggers that code path.

Though I'm not sure why nobody else has encountered this?

Could you provide the full config you're using?

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party and removed triage Waiting for team members to take a look labels Sep 8, 2020
@hjkcai
Copy link
Author

hjkcai commented Sep 9, 2020

Thanks for reply. I will try to make a minimal reproduction.

BTW, the possible infinite loop is still exist in the code path. Maybe we need to figure out what triggers it.

@bradzacher
Copy link
Member

Our tests only run on the latest TS version because nobody's spent the time to investigate / build out infra for multi-version testing.

Hence the passing test.

You're running TS 3.7, which uses a different code-path to the latest TS version (they made a breaking change to non-null asserted optional chains in TS 3.9).

Though yeah I'm not sure why nobody else as run into an infinite loop.

@hjkcai
Copy link
Author

hjkcai commented Sep 10, 2020 •
edited
Loading

Yes. TS 3.7 causes the problem. I opened an individual project using:

{
  "dependencies": {
    "@typescript-eslint/eslint-plugin": "^4.1.1-alpha.7",
    "@typescript-eslint/parser": "^4.1.1-alpha.7",
    "eslint": "^7.8.1",
    "typescript": "^3.7.5"
  }
}
{
  "compilerOptions": {
    "target": "es2018",
    "strict": true
  }
}
module.exports = {
  parser: '@typescript-eslint/parser',
  parserOptions: {
    project: './tsconfig.json'
  },
  plugins: ['@typescript-eslint'],
  rules: {
    "@typescript-eslint/no-non-null-asserted-optional-chain": "error"
  }
}
// test.ts
let foo1: { bar: { baz: string } } | undefined;

console.log(foo1?.bar!.baz);
foo1?.bar!.baz

Executing eslint never stops.

npx eslint test.ts

The problem is solved after upgrading TypeScript to 3.9

I will upgrade my project to a higher version of TypeScript firstly. Please feel free to take time to find out what's broken 😄

@bradzacher bradzacher added bug Something isn't working and removed awaiting response Issues waiting for a reply from the OP or another party labels Sep 10, 2020
@tadhgmister
Copy link
Contributor

It may be desirable to add an internal forceUsing3.7Logic option so testing can hit the old logic. currently that whole section is untested.

@bradzacher
Copy link
Member

I'd rather implement a full solution for testing old TS versions rather than adding per-rule hacks.
See discussion in #1752

@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Go ahead, send a pull request that resolves this issue label Feb 24, 2022
@armano2 armano2 mentioned this issue May 30, 2022
Merged
3 tasks
@YeeJone YeeJone mentioned this issue Jul 24, 2022
Closed
3 tasks
@bradzacher bradzacher mentioned this issue Nov 2, 2022
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member

#5915 is merged into #5886; closing this issue now accordingly. It'll be released as a part of the v6 major release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
4 participants
@hjkcai @JoshuaKGoldberg @bradzacher @tadhgmister