Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Repo: setup a GH action to help validate and educate PR title #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue May 30, 2022 · 0 comments · Fixed by #6075
Closed

Repo: setup a GH action to help validate and educate PR title #5110

bradzacher opened this issue May 30, 2022 · 0 comments · Fixed by #6075
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@bradzacher
Copy link
Member

Suggestion

Spinning off of #4981 (/#4962)

We used to have https://github.com/zeke/semantic-pull-requests setup and working as a CI step, however it appears to no longer work. I'm not sure why!

I've double checked and we have the app installed in the repo so it should just work?

Maybe because we don't have a config? It might be worth trying to configure it

File: .github/semantic.yml

enabled: true
titleOnly: true
scopes:
  - ast-utils
  - ...
types:
  - feat
  - fix
  - docs
  - chore
  - test
  - revert

Otherwise, given that we're all-in on GH actions - we could just setup a GH action for this!
First hit on google is https://github.com/amannn/action-semantic-pull-request.
This might be the better action so we can reduce our app surface area and better monitor the things we're using.
@bradzacher bradzacher added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels May 30, 2022
@bradzacher bradzacher mentioned this issue May 30, 2022
Merged
3 tasks
@bradzacher bradzacher mentioned this issue Nov 24, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add action to enforce semantic-pr titles typescript-eslint/typescript-eslint
1 participant
@bradzacher