Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: on the Rules page of the website, clicking any of the filter scrolls the page to the top if #hash is present in the URL #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
andreww2012 opened this issue Sep 20, 2023 · 2 comments
Closed
4 tasks done

Bug: on the Rules page of the website, clicking any of the filter scrolls the page to the top if #hash is present in the URL #7684

andreww2012 opened this issue Sep 20, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@andreww2012
Copy link

andreww2012 commented Sep 20, 2023 •
edited
Loading

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Relevant Package

website

Playground Link

No response

Repro Code

  • Go to https://typescript-eslint.io/rules/ in the latest Firefox or Chrome on desktop.
  • Click "Extension Rules" on the right.
  • Activate any of the filters, for example click "Config Group" -> "recommended".
  • Page scrolls to the top (but the chosen filter will be applied). This only happens when #hash is present in the URL. #hash can be any non-empty string, not specifically ID of the sections listed in the right column.
@andreww2012 andreww2012 added bug Something isn't working triage Waiting for team members to take a look labels Sep 20, 2023
@artur-janik artur-janik mentioned this issue Oct 18, 2023
Closed
3 tasks
@artur-janik
Copy link

artur-janik commented Oct 18, 2023 •
edited
Loading

Small change is required to preserve hash during filter selection. I can drop PR if maintainers can triage this issue.

(Sorry for preemptive PR - didn't knew it would get linked to issue when I make it to my fork, and not to original repo 😢)

@JoshuaKGoldberg
Copy link
Member

Ah, shoot, sorry - missed this! I think this was solved by #7666 actually. So, this was a 👍 issue when it was filed, but was superseded by the removal of the second table.

@JoshuaKGoldberg JoshuaKGoldberg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg removed the triage Waiting for team members to take a look label Oct 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue-7684 | Preserve url hash during rules table filtering artur-janik/typescript-eslint
3 participants
@JoshuaKGoldberg @andreww2012 @artur-janik