-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Repo: Make utility for static member access #8323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1! It would be nice to make these checks consistent throughout the plugin codebase. There are a few examples that can be changed as part of this refactor:
|
Whew, what a list! +1 to this from me 🙂 thanks for filing + looking! |
I believe these guys could similarly be replaced with a utility, as well as probably a few more places in that file typescript-eslint/packages/eslint-plugin/src/rules/no-floating-promises.ts Lines 424 to 446 in 82cb9dd
|
So it doesn't get lost: #8412 has another one for |
Noticed this while working on #8952:
|
Suggestion
This is a refactoring opportunity that comes from #8216 (comment).
In short, it may be a common pattern to want to check for either code that looks like
or
This could be extracted to a utility with approximate usage
An example implementation of this is 581e9ae#diff-5af06c156c2d34d6ea1d2b8f91d583d82d7e629cbd5226145c6c0b72449bcfb2R298, implemented in a way that did not aim to be more generic than the needs of that specific module. This might be possible to replace with a more general utility
The text was updated successfully, but these errors were encountered: