Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Repo: don't install dependencies for the entire repo in "Semantic Breaking Change PR" workflow #9447

New issue
New issue
Closed
#9533
Closed
Repo: don't install dependencies for the entire repo in "Semantic Breaking Change PR" workflow#9447
#9533
Labels
locked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsteam assignedA member of the typescript-eslint team should work on this.
@auvred

Description

@auvred
auvred
opened on Jun 28, 2024

Suggestion

Is there any reason why we want to install deps before running the breaking-pr-check action? It does not import any repo-specific packages:

typescript-eslint/.github/actions/breaking-pr-check/index.js

Lines 1 to 4 in 40fed48

const core = require('@actions/core');
const github = require('@actions/github');
function raiseError(message) {

Suggestion: let's remove this line?

typescript-eslint/.github/workflows/semantic-breaking-change-pr.yml

Line 18 in 40fed48

- uses: ./.github/actions/prepare-install

I noticed this, because it takes ~2 mins to run prepare-install and ~0 seconds to validate PR title (https://github.com/typescript-eslint/typescript-eslint/actions/runs/9712997933/job/26808863383?pr=9444)

prepare-install action took 2 minutes to run and breaking-pr-check finished instantly

cc @yeonjuan

Metadata

Metadata

Assignees

No one assigned

    Labels

    locked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsteam assignedA member of the typescript-eslint team should work on this.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions