Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug(eslint-plugin): [no-floating-promises] missing suggestions property on tests from #9263 checkThenables #9516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abrahamguo opened this issue Jul 8, 2024 · 0 comments · Fixed by #9515
Closed

Bug(eslint-plugin): [no-floating-promises] missing suggestions property on tests from #9263 checkThenables #9516

abrahamguo opened this issue Jul 8, 2024 · 0 comments · Fixed by #9515
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@abrahamguo
Copy link
Contributor

Suggestion

Tests added in #9263 were missing the suggestions property, causing a pipeline failure on main.
@abrahamguo abrahamguo added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look labels Jul 8, 2024
@abrahamguo abrahamguo changed the title Bug: [no-floating-promises] missing suggestions property on tests from #9263 Bug(eslint-plugin): [no-floating-promises] missing suggestions property on tests from #9263 Jul 8, 2024
@abrahamguo abrahamguo mentioned this issue Jul 8, 2024
Merged
3 tasks
@abrahamguo abrahamguo changed the title Bug(eslint-plugin): [no-floating-promises] missing suggestions property on tests from #9263 Bug(eslint-plugin): [no-floating-promises] missing suggestions property on tests from #9263 checkThenables Jul 8, 2024
@kirkwaiblinger kirkwaiblinger added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Jul 8, 2024
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jul 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
2 participants
@abrahamguo @kirkwaiblinger