Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(eslint-plugin): [no-unused-vars] support explicit resource management with ignoreUsingDeclarations option #11456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 3, 2025
Merged

feat(eslint-plugin): [no-unused-vars] support explicit resource management with ignoreUsingDeclarations option #11456

merged 13 commits into from
Oct 3, 2025

Conversation

@nayounsang
Copy link
Contributor

@nayounsang nayounsang commented Aug 5, 2025 •
edited
Loading

PR Checklist

Overview

TODO: docs? maybe it can skip. Because option depends on eslint

  • As eslint supports explict resource management(using, await using) with ignoreUsingDeclarations option,
    Add boolean type option, default is false. [ref](Ignore even if not referenced in the code block.)
  • When ignoreUsingDeclarations is enable, ignore even if not referenced in the code block.
// pass
{
  using foo = getResource();
}
  • Implement this with options.ignoreUsingDeclarations is enable && def.parent.kind is using or await using conditions.

ref

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Aug 5, 2025

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 5, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit afa9b92
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68946db093170000084bb9e4
😎 Deploy Preview https://deploy-preview-11456--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nayounsang nayounsang marked this pull request as draft August 5, 2025 06:28
@nx-cloud
Copy link

nx-cloud bot commented Aug 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit afa9b92

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 30s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 13s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 2s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-07 09:22:22 UTC

@codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (88b063e) to head (afa9b92).
⚠️ Report is 125 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11456   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files         505      505           
  Lines       51121    51137   +16     
  Branches     8413     8419    +6     
=======================================
+ Hits        46459    46475   +16     
  Misses       4648     4648           
  Partials       14       14
Flag Coverage Δ
unittest 90.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nayounsang nayounsang marked this pull request as ready for review August 6, 2025 07:44
@injae-kim injae-kim mentioned this pull request Aug 6, 2025
Closed
4 tasks
kirkwaiblinger
kirkwaiblinger requested changes Aug 6, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just requesting a bit of alignment with eslint/eslint#19828

Thanks!

@kirkwaiblinger kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Aug 6, 2025
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 7, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell! 🙌

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 3, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8de997e into typescript-eslint:main Oct 3, 2025
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger Awaiting requested review from kirkwaiblinger

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [no-unused-vars] support explicit resource management

3 participants

@nayounsang @JoshuaKGoldberg @kirkwaiblinger