From ac6071138fb5c6cf86756d6a8c3c756b479a1768 Mon Sep 17 00:00:00 2001 From: Armano Date: Sat, 25 Jan 2020 21:12:36 +0100 Subject: [PATCH 1/3] test: fix vscode launch configuration for windows --- .vscode/launch.json | 128 ++++++++++++++++++++++---------------------- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 9f1633f32aba..6b79f74f517b 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -4,69 +4,69 @@ // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 "version": "0.2.0", "configurations": [ - { - "type": "node", - "request": "launch", - "name": "Jest Test Current eslint-plugin Rule", - "cwd": "${workspaceFolder}/packages/eslint-plugin/", - "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", - "args": [ - "--runInBand", - "--no-coverage", - // needs the '' around it so that the () are properly handled - "'tests/(.+/)?${fileBasenameNoExtension}'" - ], - "sourceMaps": true, - "console": "integratedTerminal", - "internalConsoleOptions": "neverOpen" - }, - { - "type": "node", - "request": "launch", - "name": "Jest Test Current eslint-plugin-internal Rule", - "cwd": "${workspaceFolder}/packages/eslint-plugin-internal/", - "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", - "args": [ - "--runInBand", - "--no-coverage", - // needs the '' around it so that the () are properly handled - "'tests/(.+/)?${fileBasenameNoExtension}'" - ], - "sourceMaps": true, - "console": "integratedTerminal", - "internalConsoleOptions": "neverOpen" - }, - { - "type": "node", - "request": "launch", - "name": "Run currently opened typescript-estree test", - "cwd": "${workspaceFolder}/packages/typescript-estree/", - "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", - "args": [ - "--runInBand", - "--no-cache", - "--no-coverage", - "${relativeFile}" - ], - "sourceMaps": true, - "console": "integratedTerminal", - "internalConsoleOptions": "neverOpen" - }, - { - "type": "node", - "request": "launch", - "name": "Run currently opened parser test", - "cwd": "${workspaceFolder}/packages/parser/", - "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", - "args": [ - "--runInBand", - "--no-cache", - "--no-coverage", - "${relativeFile}" - ], - "sourceMaps": true, - "console": "integratedTerminal", - "internalConsoleOptions": "neverOpen" - } + { + "type": "node", + "request": "launch", + "name": "Jest Test Current eslint-plugin Rule", + "cwd": "${workspaceFolder}/packages/eslint-plugin/", + "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", + "args": [ + "--runInBand", + "--no-cache", + "--no-coverage", + "${fileBasename}" + ], + "sourceMaps": true, + "console": "integratedTerminal", + "internalConsoleOptions": "neverOpen" + }, + { + "type": "node", + "request": "launch", + "name": "Jest Test Current eslint-plugin-internal Rule", + "cwd": "${workspaceFolder}/packages/eslint-plugin-internal/", + "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", + "args": [ + "--runInBand", + "--no-cache", + "--no-coverage", + "${fileBasename}" + ], + "sourceMaps": true, + "console": "integratedTerminal", + "internalConsoleOptions": "neverOpen" + }, + { + "type": "node", + "request": "launch", + "name": "Run currently opened typescript-estree test", + "cwd": "${workspaceFolder}/packages/typescript-estree/", + "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", + "args": [ + "--runInBand", + "--no-cache", + "--no-coverage", + "${fileBasename}" + ], + "sourceMaps": true, + "console": "integratedTerminal", + "internalConsoleOptions": "neverOpen" + }, + { + "type": "node", + "request": "launch", + "name": "Run currently opened parser test", + "cwd": "${workspaceFolder}/packages/parser/", + "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", + "args": [ + "--runInBand", + "--no-cache", + "--no-coverage", + "${fileBasename}" + ], + "sourceMaps": true, + "console": "integratedTerminal", + "internalConsoleOptions": "neverOpen" + } ] } From e839afe7e8a8fd355e3845bbbd68bc7f253a5b84 Mon Sep 17 00:00:00 2001 From: Armano Date: Sat, 25 Jan 2020 21:13:06 +0100 Subject: [PATCH 2/3] test: add missing experimental-utils test runner --- .vscode/launch.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.vscode/launch.json b/.vscode/launch.json index 6b79f74f517b..32e617089174 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -67,6 +67,22 @@ "sourceMaps": true, "console": "integratedTerminal", "internalConsoleOptions": "neverOpen" + }, + { + "type": "node", + "request": "launch", + "name": "Run currently opened experimental-utils test", + "cwd": "${workspaceFolder}/packages/experimental-utils/", + "program": "${workspaceFolder}/node_modules/jest/bin/jest.js", + "args": [ + "--runInBand", + "--no-cache", + "--no-coverage", + "${fileBasename}" + ], + "sourceMaps": true, + "console": "integratedTerminal", + "internalConsoleOptions": "neverOpen" } ] } From b4827784fffec4552c6d6896d5f091721d65d8c9 Mon Sep 17 00:00:00 2001 From: Armano Date: Sun, 26 Jan 2020 23:51:54 +0100 Subject: [PATCH 3/3] chore: apply changes from code review --- .vscode/launch.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 32e617089174..eee0937502c8 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -14,7 +14,7 @@ "--runInBand", "--no-cache", "--no-coverage", - "${fileBasename}" + "${fileBasenameNoExtension}" ], "sourceMaps": true, "console": "integratedTerminal", @@ -30,7 +30,7 @@ "--runInBand", "--no-cache", "--no-coverage", - "${fileBasename}" + "${fileBasenameNoExtension}" ], "sourceMaps": true, "console": "integratedTerminal", @@ -78,7 +78,7 @@ "--runInBand", "--no-cache", "--no-coverage", - "${fileBasename}" + "${fileBasenameNoExtension}" ], "sourceMaps": true, "console": "integratedTerminal",