From 52020f4f2d13dd6978dc1461c461bcf28688dd62 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Fri, 29 Apr 2022 12:08:48 -0400 Subject: [PATCH 1/2] chore: removed noUnused(Locals|Parameters) from tsconfig.base.json --- tsconfig.base.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/tsconfig.base.json b/tsconfig.base.json index c490a4a2eee2..7bb2b5a7fa8f 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -9,8 +9,6 @@ "module": "commonjs", "moduleResolution": "node", "noImplicitReturns": true, - "noUnusedLocals": true, - "noUnusedParameters": true, "pretty": true, "skipLibCheck": true, "sourceMap": true, From 090bf494a2a283be0f268f7f81e1320d73a9c3dc Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Fri, 29 Apr 2022 13:28:26 -0400 Subject: [PATCH 2/2] fix: unused directives --- packages/ast-spec/tests/PunctuatorTokenToText.type-test.ts | 1 - packages/ast-spec/tests/ast-node-types.type-test.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/ast-spec/tests/PunctuatorTokenToText.type-test.ts b/packages/ast-spec/tests/PunctuatorTokenToText.type-test.ts index 32deee0bea9a..e92f2a7db0c5 100644 --- a/packages/ast-spec/tests/PunctuatorTokenToText.type-test.ts +++ b/packages/ast-spec/tests/PunctuatorTokenToText.type-test.ts @@ -2,7 +2,6 @@ import type { PunctuationSyntaxKind } from 'typescript'; import type { PunctuatorTokenToText } from '../src'; -// @ts-expect-error: purposely unused type _Test = { readonly [T in PunctuationSyntaxKind]: PunctuatorTokenToText[T]; // If there are any PunctuationSyntaxKind members that don't have a diff --git a/packages/ast-spec/tests/ast-node-types.type-test.ts b/packages/ast-spec/tests/ast-node-types.type-test.ts index 7cc247f2d094..dc3d9a1bd506 100644 --- a/packages/ast-spec/tests/ast-node-types.type-test.ts +++ b/packages/ast-spec/tests/ast-node-types.type-test.ts @@ -9,7 +9,6 @@ type AllKeys = { type TakesString> = T; -// @ts-expect-error: purposely unused type _Test = // forcing the test onto a new line so it isn't covered by the expect error // If there are any enum members that don't have a corresponding TSESTree.Node, then this line will error with "Type 'string | number | symbol' is not assignable to type 'string'."