From f6fa30977e79984fa2b45c224adea97c3a53c36d Mon Sep 17 00:00:00 2001 From: Tapan Prakash Date: Sun, 25 Dec 2022 22:33:32 +0530 Subject: [PATCH 1/4] test(website): Add AST viewer test case --- packages/website/tests/playground.spec.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/website/tests/playground.spec.ts b/packages/website/tests/playground.spec.ts index e7aa1d2e057b..609960156d3f 100644 --- a/packages/website/tests/playground.spec.ts +++ b/packages/website/tests/playground.spec.ts @@ -46,6 +46,19 @@ test.describe('Playground', () => { await expect(page.getByText('let value: string[];')).toBeVisible(); await expect(page.getByText('All is ok!')).toBeVisible(); }); + + test('AST Viewer', async ({ page }) => { + // 1. Type some valid code in the playground + await writeInEditor(page, 'let value: Array;'); + // 2. Enable AST viewer + await page + .getByRole('combobox', { name: 'AST Viewer' }) + .selectOption({ label: 'ESTree' }); + // 3. Validate variable declaration block exist in AST viewer + await expect( + page.getByRole('link', { name: 'VariableDeclaration' }), + ).toBeVisible(); + }); }); async function writeInEditor(page: Page, text: string): Promise { From b61d1cebf1e51a57a5452c31ea560c01e0b42dde Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 26 Dec 2022 12:00:45 -0500 Subject: [PATCH 2/4] Update packages/website/tests/playground.spec.ts --- packages/website/tests/playground.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/website/tests/playground.spec.ts b/packages/website/tests/playground.spec.ts index 609960156d3f..dd8b14cb29ed 100644 --- a/packages/website/tests/playground.spec.ts +++ b/packages/website/tests/playground.spec.ts @@ -54,7 +54,7 @@ test.describe('Playground', () => { await page .getByRole('combobox', { name: 'AST Viewer' }) .selectOption({ label: 'ESTree' }); - // 3. Validate variable declaration block exist in AST viewer + // 3. Validate variable declaration block exists in AST viewer await expect( page.getByRole('link', { name: 'VariableDeclaration' }), ).toBeVisible(); From 5ef34bd99a724e8dfb4a2d73aa7ddffc64db0399 Mon Sep 17 00:00:00 2001 From: Tapan Prakash Date: Sat, 31 Dec 2022 20:07:49 +0530 Subject: [PATCH 3/4] test(website): workaround for AST viewer failing test case --- packages/website/tests/playground.spec.ts | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/website/tests/playground.spec.ts b/packages/website/tests/playground.spec.ts index dd8b14cb29ed..771004d8f81d 100644 --- a/packages/website/tests/playground.spec.ts +++ b/packages/website/tests/playground.spec.ts @@ -50,11 +50,23 @@ test.describe('Playground', () => { test('AST Viewer', async ({ page }) => { // 1. Type some valid code in the playground await writeInEditor(page, 'let value: Array;'); + + /* Workaround for text editor wiping text. switch between lint editor and + code editor */ + await page.getByRole('tab', { name: 'eslintrc' }).click(); + await page.getByRole('button', { name: 'Visual Editor' }).click(); + await page.getByRole('button', { name: 'Close' }).click(); + await page.getByRole('tab', { name: 'code' }).click(); + // 2. Enable AST viewer await page .getByRole('combobox', { name: 'AST Viewer' }) .selectOption({ label: 'ESTree' }); - // 3. Validate variable declaration block exists in AST viewer + + // 3. Type some valid code in the playground + await writeInEditor(page, 'let value: Array;'); + + // 4. Validate variable declaration block exists in AST viewer await expect( page.getByRole('link', { name: 'VariableDeclaration' }), ).toBeVisible(); From 9a3276d2995616f5734784d0a07b8c083ff1f1be Mon Sep 17 00:00:00 2001 From: Tapan Prakash Date: Wed, 5 Apr 2023 20:06:59 +0530 Subject: [PATCH 4/4] test(website): remove workaround for failing test --- packages/website/tests/playground.spec.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/packages/website/tests/playground.spec.ts b/packages/website/tests/playground.spec.ts index c91cf5a07ddd..340aa2b1e4bb 100644 --- a/packages/website/tests/playground.spec.ts +++ b/packages/website/tests/playground.spec.ts @@ -52,13 +52,6 @@ test.describe('Playground', () => { // 1. Type some valid code in the playground await writeInEditor(page, 'let value: Array;'); - /* Workaround for text editor wiping text. switch between lint editor and - code editor */ - await page.getByRole('tab', { name: 'eslintrc' }).click(); - await page.getByRole('button', { name: 'Visual Editor' }).click(); - await page.getByRole('button', { name: 'Close' }).click(); - await page.getByRole('tab', { name: 'code' }).click(); - // 2. Enable AST viewer await page .getByRole('combobox', { name: 'AST Viewer' })