From 049bd978128d4c6f8af495664684c67be40bcf8c Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Wed, 24 May 2023 11:50:43 +0300 Subject: [PATCH 1/2] docs: fleshed out RFC and Technical Discussions forms --- .github/DISCUSSION_TEMPLATE/rfcs.yml | 2 +- .../technical-discussions.yml | 24 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 .github/DISCUSSION_TEMPLATE/technical-discussions.yml diff --git a/.github/DISCUSSION_TEMPLATE/rfcs.yml b/.github/DISCUSSION_TEMPLATE/rfcs.yml index e9467392b44d..035f10837795 100644 --- a/.github/DISCUSSION_TEMPLATE/rfcs.yml +++ b/.github/DISCUSSION_TEMPLATE/rfcs.yml @@ -14,11 +14,11 @@ body: - attributes: label: Before you submit your RFC, please confirm the following. If any of these required steps are not taken, we may not be able to review your RFC. Help us to help you! options: + - label: I have [read the discussions guidelines](https://typescript-eslint.io/contributing/discussions) and per those guidelines, this fits a discussion category, _not_ a help request or standard issue. - label: I have [searched for related discussions](https://github.com/typescript-eslint/typescript-eslint/discussions) and [searched for related issues](https://github.com/typescript-eslint/typescript-eslint/issues) and found none that match my proposal. required: true - label: I have [read the FAQ](https://typescript-eslint.io/linting/troubleshooting) and my problem is not listed. required: true id: required-checks type: checkboxes -labels: ['rfc'] title: Your Title Here diff --git a/.github/DISCUSSION_TEMPLATE/technical-discussions.yml b/.github/DISCUSSION_TEMPLATE/technical-discussions.yml new file mode 100644 index 000000000000..1dbdb8b06280 --- /dev/null +++ b/.github/DISCUSSION_TEMPLATE/technical-discussions.yml @@ -0,0 +1,24 @@ +body: + - attributes: + label: Body + value: | + Body of the technical discussion... + id: body + type: textarea + - attributes: + label: Additional Info + value: | + Any additional info... + id: additional + type: textarea + - attributes: + label: Before you submit your discussion, please confirm the following. If any of these required steps are not taken, we may not be able to review your RFC. Help us to help you! + options: + - label: I have [read the discussions guidelines](https://typescript-eslint.io/contributing/discussions) and per those guidelines, this fits a discussion category, _not_ a help request or standard issue. + - label: I have [searched for related discussions](https://github.com/typescript-eslint/typescript-eslint/discussions) and [searched for related issues](https://github.com/typescript-eslint/typescript-eslint/issues) and found none that match my proposal. + required: true + - label: I have [read the FAQ](https://typescript-eslint.io/linting/troubleshooting) and my problem is not listed. + required: true + id: required-checks + type: checkboxes +title: Your Title Here From f023bf52193dd280afa21a2a5fb011c2a554d71e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Wed, 24 May 2023 16:28:05 +0300 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Brad Zacher --- .github/DISCUSSION_TEMPLATE/rfcs.yml | 1 + .github/DISCUSSION_TEMPLATE/technical-discussions.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/DISCUSSION_TEMPLATE/rfcs.yml b/.github/DISCUSSION_TEMPLATE/rfcs.yml index 035f10837795..446767111f60 100644 --- a/.github/DISCUSSION_TEMPLATE/rfcs.yml +++ b/.github/DISCUSSION_TEMPLATE/rfcs.yml @@ -15,6 +15,7 @@ body: label: Before you submit your RFC, please confirm the following. If any of these required steps are not taken, we may not be able to review your RFC. Help us to help you! options: - label: I have [read the discussions guidelines](https://typescript-eslint.io/contributing/discussions) and per those guidelines, this fits a discussion category, _not_ a help request or standard issue. + required: true - label: I have [searched for related discussions](https://github.com/typescript-eslint/typescript-eslint/discussions) and [searched for related issues](https://github.com/typescript-eslint/typescript-eslint/issues) and found none that match my proposal. required: true - label: I have [read the FAQ](https://typescript-eslint.io/linting/troubleshooting) and my problem is not listed. diff --git a/.github/DISCUSSION_TEMPLATE/technical-discussions.yml b/.github/DISCUSSION_TEMPLATE/technical-discussions.yml index 1dbdb8b06280..7c8f96d2fca4 100644 --- a/.github/DISCUSSION_TEMPLATE/technical-discussions.yml +++ b/.github/DISCUSSION_TEMPLATE/technical-discussions.yml @@ -15,6 +15,7 @@ body: label: Before you submit your discussion, please confirm the following. If any of these required steps are not taken, we may not be able to review your RFC. Help us to help you! options: - label: I have [read the discussions guidelines](https://typescript-eslint.io/contributing/discussions) and per those guidelines, this fits a discussion category, _not_ a help request or standard issue. + required: true - label: I have [searched for related discussions](https://github.com/typescript-eslint/typescript-eslint/discussions) and [searched for related issues](https://github.com/typescript-eslint/typescript-eslint/issues) and found none that match my proposal. required: true - label: I have [read the FAQ](https://typescript-eslint.io/linting/troubleshooting) and my problem is not listed.