From 92d45fc89aef6c33c0189144c0d4876cec89c6cc Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Sat, 2 Sep 2023 10:23:53 -0700 Subject: [PATCH 1/5] update pull_requests.mdx --- docs/contributing/Pull_Requests.mdx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx index 6a65284aaa6c..64afc182262b 100644 --- a/docs/contributing/Pull_Requests.mdx +++ b/docs/contributing/Pull_Requests.mdx @@ -22,6 +22,8 @@ Please don't: - Comment on an existing PR asking for updates - Reasoning: Your PR hasn't been forgotten! The volunteer maintainers have limited time to work on the project, and they will get to it as soon as they are able. - One exception: if a PR has been blocked on a question to a maintainer for 3 or more months, please ping us - we probably lost track of it. +- Comment on a closed PRs. + - Reasoning: It is much easier for maintainers to not lose track of things if they are posted as issues. If you think there’s a bug in typescript-eslint, the right way to ask is to [file a new issue](https://github.com/typescript-eslint/typescript-eslint/issues/new/choose). The issue templates include helpful & necessary practices such as making sure you're on the latest version of all our packages. ### Raising a PR From 82795c6acd7d330336ace20cf1b82ab9d65420b8 Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Sat, 2 Sep 2023 12:47:26 -0700 Subject: [PATCH 2/5] update docs/contributing/Pull_Requests.mdx --- docs/contributing/Pull_Requests.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx index 64afc182262b..06828397e663 100644 --- a/docs/contributing/Pull_Requests.mdx +++ b/docs/contributing/Pull_Requests.mdx @@ -23,7 +23,7 @@ Please don't: - Reasoning: Your PR hasn't been forgotten! The volunteer maintainers have limited time to work on the project, and they will get to it as soon as they are able. - One exception: if a PR has been blocked on a question to a maintainer for 3 or more months, please ping us - we probably lost track of it. - Comment on a closed PRs. - - Reasoning: It is much easier for maintainers to not lose track of things if they are posted as issues. If you think there’s a bug in typescript-eslint, the right way to ask is to [file a new issue](https://github.com/typescript-eslint/typescript-eslint/issues/new/choose). The issue templates include helpful & necessary practices such as making sure you're on the latest version of all our packages. + - Reasoning: It is much easier for maintainers to not lose track of things if they are posted as issues. If you think there’s a bug in typescript-eslint, the right way to ask is to [file a new issue](https://github.com/typescript-eslint/typescript-eslint/issues/new/choose). The issue templates include helpful & necessary practices such as making sure you're on the latest version of all our packages. ### Raising a PR From 137fbdf0b5e582fc420b882311fdd6677d0cdfaf Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Sat, 2 Sep 2023 14:05:42 -0700 Subject: [PATCH 3/5] update docs/contributing/Pull_Requests.mdx Co-authored-by: Joshua Chen --- docs/contributing/Pull_Requests.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx index 06828397e663..db520b9d1ae1 100644 --- a/docs/contributing/Pull_Requests.mdx +++ b/docs/contributing/Pull_Requests.mdx @@ -22,7 +22,7 @@ Please don't: - Comment on an existing PR asking for updates - Reasoning: Your PR hasn't been forgotten! The volunteer maintainers have limited time to work on the project, and they will get to it as soon as they are able. - One exception: if a PR has been blocked on a question to a maintainer for 3 or more months, please ping us - we probably lost track of it. -- Comment on a closed PRs. +- Comment on a closed PR. - Reasoning: It is much easier for maintainers to not lose track of things if they are posted as issues. If you think there’s a bug in typescript-eslint, the right way to ask is to [file a new issue](https://github.com/typescript-eslint/typescript-eslint/issues/new/choose). The issue templates include helpful & necessary practices such as making sure you're on the latest version of all our packages. ### Raising a PR From dce68b67df4fb9eb2d47eecebfe883e4030e8cc8 Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Sat, 2 Sep 2023 14:06:07 -0700 Subject: [PATCH 4/5] update docs/contributing/Pull_Requests.mdx Co-authored-by: Joshua Chen --- docs/contributing/Pull_Requests.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx index db520b9d1ae1..fdf1afc6f61b 100644 --- a/docs/contributing/Pull_Requests.mdx +++ b/docs/contributing/Pull_Requests.mdx @@ -23,7 +23,7 @@ Please don't: - Reasoning: Your PR hasn't been forgotten! The volunteer maintainers have limited time to work on the project, and they will get to it as soon as they are able. - One exception: if a PR has been blocked on a question to a maintainer for 3 or more months, please ping us - we probably lost track of it. - Comment on a closed PR. - - Reasoning: It is much easier for maintainers to not lose track of things if they are posted as issues. If you think there’s a bug in typescript-eslint, the right way to ask is to [file a new issue](https://github.com/typescript-eslint/typescript-eslint/issues/new/choose). The issue templates include helpful & necessary practices such as making sure you're on the latest version of all our packages. + - Reasoning: It is much easier for maintainers to not lose track of things if they are posted as issues. If you think there's a bug in typescript-eslint, the right way to ask is to [file a new issue](https://github.com/typescript-eslint/typescript-eslint/issues/new/choose). The issue templates include helpful & necessary practices such as making sure you're on the latest version of all our packages. You can provide the link to the relevant PR to add more context. ### Raising a PR From 0f2a6c0bf473aaa990a1e63a3989858a8914cfb2 Mon Sep 17 00:00:00 2001 From: Sylvia Favello <90116354+sfavello@users.noreply.github.com> Date: Tue, 5 Sep 2023 13:05:47 -0700 Subject: [PATCH 5/5] Update docs/contributing/Pull_Requests.mdx Co-authored-by: Joshua Chen --- docs/contributing/Pull_Requests.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx index fdf1afc6f61b..4a6194c64a03 100644 --- a/docs/contributing/Pull_Requests.mdx +++ b/docs/contributing/Pull_Requests.mdx @@ -22,7 +22,7 @@ Please don't: - Comment on an existing PR asking for updates - Reasoning: Your PR hasn't been forgotten! The volunteer maintainers have limited time to work on the project, and they will get to it as soon as they are able. - One exception: if a PR has been blocked on a question to a maintainer for 3 or more months, please ping us - we probably lost track of it. -- Comment on a closed PR. +- Comment on a closed PR - Reasoning: It is much easier for maintainers to not lose track of things if they are posted as issues. If you think there's a bug in typescript-eslint, the right way to ask is to [file a new issue](https://github.com/typescript-eslint/typescript-eslint/issues/new/choose). The issue templates include helpful & necessary practices such as making sure you're on the latest version of all our packages. You can provide the link to the relevant PR to add more context. ### Raising a PR