From 785f6e987992d811cd96075a23cd48d8b0c47b77 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Wed, 3 Jul 2024 15:05:59 -0400 Subject: [PATCH 1/3] feat(ast-spec): add parent property to AccessorProperty node types --- packages/ast-spec/src/element/AccessorProperty/spec.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/ast-spec/src/element/AccessorProperty/spec.ts b/packages/ast-spec/src/element/AccessorProperty/spec.ts index 739481e9c231..02753eba1c2a 100644 --- a/packages/ast-spec/src/element/AccessorProperty/spec.ts +++ b/packages/ast-spec/src/element/AccessorProperty/spec.ts @@ -3,15 +3,18 @@ import type { PropertyDefinitionComputedNameBase, PropertyDefinitionNonComputedNameBase, } from '../../base/PropertyDefinitionBase'; +import type { ClassBody } from '../../special/ClassBody/spec'; export interface AccessorPropertyComputedName extends PropertyDefinitionComputedNameBase { type: AST_NODE_TYPES.AccessorProperty; + parent: ClassBody; } export interface AccessorPropertyNonComputedName extends PropertyDefinitionNonComputedNameBase { type: AST_NODE_TYPES.AccessorProperty; + parent: ClassBody; } export type AccessorProperty = From fbebcef97db6ede3f8a5faed032ff6928c1d9e1b Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Wed, 3 Jul 2024 20:20:11 -0400 Subject: [PATCH 2/3] Right, move them to augmentations --- packages/ast-spec/src/element/AccessorProperty/spec.ts | 3 --- packages/types/src/ts-estree.ts | 8 ++++++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/ast-spec/src/element/AccessorProperty/spec.ts b/packages/ast-spec/src/element/AccessorProperty/spec.ts index 02753eba1c2a..739481e9c231 100644 --- a/packages/ast-spec/src/element/AccessorProperty/spec.ts +++ b/packages/ast-spec/src/element/AccessorProperty/spec.ts @@ -3,18 +3,15 @@ import type { PropertyDefinitionComputedNameBase, PropertyDefinitionNonComputedNameBase, } from '../../base/PropertyDefinitionBase'; -import type { ClassBody } from '../../special/ClassBody/spec'; export interface AccessorPropertyComputedName extends PropertyDefinitionComputedNameBase { type: AST_NODE_TYPES.AccessorProperty; - parent: ClassBody; } export interface AccessorPropertyNonComputedName extends PropertyDefinitionNonComputedNameBase { type: AST_NODE_TYPES.AccessorProperty; - parent: ClassBody; } export type AccessorProperty = diff --git a/packages/types/src/ts-estree.ts b/packages/types/src/ts-estree.ts index acfd90fb9a35..87a7c3c1fe67 100644 --- a/packages/types/src/ts-estree.ts +++ b/packages/types/src/ts-estree.ts @@ -12,6 +12,14 @@ declare module './generated/ast-spec' { */ parent?: never; } + + interface AccessorPropertyComputedName { + parent: TSESTree.ClassBody; + } + + export interface AccessorPropertyNonComputedName { + parent: TSESTree.ClassBody; + } } export * as TSESTree from './generated/ast-spec'; From 33e688253bae1cc1a8ab9901cf90fdff80221708 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Thu, 4 Jul 2024 10:19:52 -0400 Subject: [PATCH 3/3] Update packages/types/src/ts-estree.ts --- packages/types/src/ts-estree.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/types/src/ts-estree.ts b/packages/types/src/ts-estree.ts index 87a7c3c1fe67..464ff4dc620c 100644 --- a/packages/types/src/ts-estree.ts +++ b/packages/types/src/ts-estree.ts @@ -17,7 +17,7 @@ declare module './generated/ast-spec' { parent: TSESTree.ClassBody; } - export interface AccessorPropertyNonComputedName { + interface AccessorPropertyNonComputedName { parent: TSESTree.ClassBody; } }