From 317cf05d5fdeb1ef43ca1d80468e5d895f6c8d8d Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Sun, 21 Aug 2022 22:48:17 +0200 Subject: [PATCH] fix: don't trigger error message on empty Source Definition response --- src/features/source-definition.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/features/source-definition.ts b/src/features/source-definition.ts index 51a5df50..e1d4daa9 100644 --- a/src/features/source-definition.ts +++ b/src/features/source-definition.ts @@ -60,10 +60,11 @@ export class SourceDefinitionCommand { reporter, }, async () => { const response = await tspClient.request(CommandTypes.FindSourceDefinition, args); - if (response.type === 'response' && response.body?.length) { - return response.body.map(reference => toLocation(reference, documents)); + if (response.type !== 'response' || !response.body) { + lspClient.showErrorMessage('No source definitions found.'); + return; } - lspClient.showErrorMessage('No source definitions found.'); + return response.body.map(reference => toLocation(reference, documents)); }); } }