fix: fix init not work on pnpm #1334 #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless I'm overlooking something, I think we can remove |
|
fullly agree, clean and beautiful now |
1 task
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm_package_jsonenv is not supported by pnpm now. (but npm and yarn works)This is not a perfect fix, the user may not run husky init in project root. in this case, we need more code that npm and yarn user doest't need, I think this is unfair. So, we can simple add one line here utill the pnpm support it.
The other way is update doc, let users define a env named
npm_package_jsonbeforehusky init, but I think that is too complex for users.