Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.52.0] Squished lines in panel #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8 tasks done
yokoffing opened this issue Sep 14, 2023 · 4 comments
Closed
8 tasks done

[1.52.0] Squished lines in panel #2817

yokoffing opened this issue Sep 14, 2023 · 4 comments
Labels
invalid not a uBlock issue

Comments

@yokoffing
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

The panel squeezes a bunch of lines together when trying to filter by request type. This seems to be a bug when compared to previous builds.

Not website related. Happens regardless of site.

Before
before filter

After
after filter

A specific URL where the issue occurs.

cnn.com

Steps to Reproduce

With filterAuthorMode = true, I cannot filter by script, frame, etc.

Expected behavior

No squished lines.

Actual behavior

Squished lines.

uBO version

1.52.0

Browser name and version

Firefox/Chrome

Operating System and version

Windows 11
@gorhill
Copy link
Member

gorhill commented Sep 14, 2023

No squished lines.

Just remove the filter -- rows which do not match your filter are minimized.

@yokoffing
Copy link
Author

yokoffing commented Sep 14, 2023 •
edited
Loading

I think I understand:

  • Before, when a filter was enabled, we hid all the other lines and only showed what was relevant.
  • In 1.52, when a filter is enabled, we show the squished lines and still only show relevant requests.

I can see a rationale for this kind of change. Sometimes I would forget that I enabled frame filter and would only see three requests in the UI on sites. Squished lines are a reminder that I have a filter enabled.

I didn't see this change in the release notes, so the UI jarred me.

@ghost ghost added the invalid not a uBlock issue label Sep 14, 2023
@ghost ghost closed this as completed Sep 14, 2023
@gorhill
Copy link
Member

gorhill commented Sep 14, 2023

I didn't see this change in the release notes, so the UI jarred me.

It's the "Add visual hint for filtered out rows in firewall pane" entry, which leads to #2632.

@yokoffing
Copy link
Author

Thank you for the links!

@garry-ut99 garry-ut99 mentioned this issue Aug 14, 2024
Closed
9 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid not a uBlock issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorhill @yokoffing