Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Tolsi/uap-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ua-parser/uap-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 7 files changed
  • 2 contributors

Commits on Feb 1, 2025

  1. formatting fixes

    I assume ruff's updated a few things since last time it was run, as it
    now fails.
    masklinn committed Feb 1, 2025
    Configuration menu
    Copy the full SHA
    5f5f338 View commit details
    Browse the repository at this point in the history
  2. Fix memoisation of lazy parser & bump version

    Reported by @Rafiot: the lazy parser is not memoised, this has limited
    effect on the basic / pure Python parser as its initialisation is
    trivial, but it *significantly* impact the re2 and regex parsers as
    they need to process regexes into a filter tree.
    
    The memoization was mistakenly removed in ua-parser#230: while refactoring
    initialisation I removed the setting of the `parser` global.
    
    - add a test to ensure the parser is correctly memoized, not
      re-instantiated every time
    - reinstate setting the global
    - add a mutex on `__getattr__`, it should only be used on first access
      and avoids two threads creating an expensive parser at the same
      time (which is a waste of CPU)
    
    Fixes ua-parser#253
    masklinn committed Feb 1, 2025
    Configuration menu
    Copy the full SHA
    ce12905 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2025

  1. builtins: fallback to package.json for uap-core version

    In case where uap-core isn't a git repo (e.g. git archive), use uap-core's `package.json` as a fallback for getting a version.
    bryteise authored Feb 15, 2025
    Configuration menu
    Copy the full SHA
    1b64406 View commit details
    Browse the repository at this point in the history
  2. Fix fallback input for release action

    Apparently the way submodules repos are configured leads to the branches not being mirrored locally (?) As such, the release job's fallback of checking out `'master'` fails whether triggered[^1] or scheduled[^2].
    
    [^1]: https://github.com/ua-parser/uap-python/actions/runs/13090871627
    [^2]: https://github.com/ua-parser/uap-python/actions/runs/13092233962
    masklinn committed Feb 15, 2025
    Configuration menu
    Copy the full SHA
    2ca789e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea7a5ae View commit details
    Browse the repository at this point in the history
  4. Clarify environment fallback

    Since the environment is required via `workflow_dispatch`, the only fallback is scheduled release in which case we're publishing to pypy.
    masklinn committed Feb 15, 2025
    Configuration menu
    Copy the full SHA
    60b35ec View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2025

  1. Fix fallback input for release action for real

    Turns out `'master'` probably worked all along as a fallback, the
    problem is that I was using `'master '`, with a trailing space, which
    was not a branch git managed to find for obvious reason, and since I
    carried the error into the fully qualified reference... is still
    didn't work.
    
    And manual triggers didn't have the issue because the tag was
    `required`, so I'd have to input the tag by hand every time, and the
    fallback value would be bypassed.
    
    - fix the fallback value
    - remove the requirement on `tag`, such that it's possible to manually
      trigger the action in a default state
    masklinn committed Mar 3, 2025
    Configuration menu
    Copy the full SHA
    997990f View commit details
    Browse the repository at this point in the history
Loading