Fix scatter corner cases

rreusser · rreusser · commit 7839661c158a · 2017-08-04T18:03:32.000-07:00
diff --git a/src/traces/scatter/plot.js b/src/traces/scatter/plot.js
@@ -204,7 +204,6 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
 
     // initialize line join data / method
     var segments = [],
-        lineSegments = [],
         makeUpdate = Lib.noop;
 
     ownFillEl3 = trace._ownFill;
@@ -270,10 +269,6 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
             pt1 = lastSegment[lastSegment.length - 1];
         }
 
-        lineSegments = segments.filter(function(s) {
-            return s.length > 1;
-        });
-
         makeUpdate = function(isEnter) {
             return function(pts) {
                 thispath = pathfn(pts);
@@ -312,7 +307,7 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
         };
     }
 
-    var lineJoin = tr.selectAll('.js-line').data(lineSegments);
+    var lineJoin = tr.selectAll('.js-line').data(segments);
 
     transition(lineJoin.exit())
         .style('opacity', 0)
diff --git a/test/image/baselines/scatter_corner_cases.png b/test/image/baselines/scatter_corner_cases.png
diff --git a/test/image/mocks/scatter_corner_cases.json b/test/image/mocks/scatter_corner_cases.json
@@ -0,0 +1,29 @@
+{
+  "data": [
+    {
+      "x": [1.5],
+      "y": [1.75],
+      "fill": "tozeroy"
+    },
+    {
+      "x": [0, 1, 2, 3],
+      "y": [1.5, null, 1.5, 1.5],
+      "fill": "tozeroy"
+    },
+    {
+      "x": [0, 1, 1.5, 2, 2.5, 3],
+      "y": [1.25, 1.25, null, 1.35, null, 1.25, 1.25],
+      "fill": "tozeroy"
+    },
+    {
+      "x": [0, 1, 2, 3],
+      "y": [1.0, 1.1, null, 1.0],
+      "fill": "tozeroy"
+    },
+    {
+      "x": [0, 1.5, 3],
+      "y": [0.75, null, 0.75],
+      "fill": "tozeroy"
+    }
+  ]
+}
