-
-
Notifications
You must be signed in to change notification settings - Fork 36
[FEEDBACK] Literal keys contents / values #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, "contents" here is meant to mean the string value represented by the syntax. In the Key section, we include this: message-format-wg/spec/syntax.md Lines 471 to 475 in 9c9ecfc
|
|one| is a literal key, and one is a literal key. According to the above |one| is not considered identical to one. It should be:
|
@macchiati Your version is probably clearer. Make a PR? |
Will do |
Fixed |
Uh oh!
There was an error while loading. Please reload this page.
Bolded is the original source.
I think this needs some clarification. The interpretation of a literal depends on the function it is supplied to. Thus 'contents' in that sense is not a data model error. I think what is meant is that |a| is equivalent to a.
If we change "contents" to "value" that helps. We do have the following, although that isn't exactly what we need; and it is off in the Data Model.
I suggest the following changes.
In the bold quoted line, change "contents" to "values".
In https://unicode.org/reports/tr35/dev/tr35-messageFormat.html#literals, add at the end of the section.
This is misleading: should be:
The text was updated successfully, but these errors were encountered: